[v5,0/4] cxl: Fix memdev qos_class sysfs attributes

Message

Dave Jiang Feb. 6, 2024, 7:03 p.m. UTC

v5:
- Only update the perf sysfs groups (Dan)
- Remove unnecessary type cast (Jonathan)

v4:
- Fix resetting of dpa_perf (Wonjae)
- Change cxl_qos_match() to return bool. (Jonathan)
- Remove unnecessary void * casting. (Jonathan)
- Replace open code with sysfs_update_groups() helper. (Jonathan)

This series provides fixes to the memdev qos_class sysfs attributes. The
current code emits duplicate sysfs attribute under the same directory and
the ram qos_class clobbers the pmem qos_class. Move the attributes under
static definitions and allow the attributes to show up under ram and pmem
directory individually.

The series also adds cxl_test support in order to allow CXL CLI add a unit
test for qos_class attributes.

Comments

Jonathan Cameron Feb. 15, 2024, 4:17 p.m. UTC | #1

On Tue, 6 Feb 2024 12:03:36 -0700
Dave Jiang <[e-mail]> wrote:

> v5:
> - Only update the perf sysfs groups (Dan)
> - Remove unnecessary type cast (Jonathan)
> 
> v4:
> - Fix resetting of dpa_perf (Wonjae)
> - Change cxl_qos_match() to return bool. (Jonathan)
> - Remove unnecessary void * casting. (Jonathan)
> - Replace open code with sysfs_update_groups() helper. (Jonathan)
> 
> This series provides fixes to the memdev qos_class sysfs attributes. The
> current code emits duplicate sysfs attribute under the same directory and
> the ram qos_class clobbers the pmem qos_class. Move the attributes under
> static definitions and allow the attributes to show up under ram and pmem
> directory individually.
> 
> The series also adds cxl_test support in order to allow CXL CLI add a unit
> test for qos_class attributes.

I see Dan has this queued up already but fwiw (excluding patch 4 because
I've not looked at the cxl-test stuff for a while).

For patches 1-3
Reviewed-by: Jonathan Cameron <[e-mail]>

Dave Jiang Feb. 15, 2024, 4:18 p.m. UTC | #2

On 2/15/24 9:17 AM, Jonathan Cameron wrote:
> On Tue, 6 Feb 2024 12:03:36 -0700
> Dave Jiang <[e-mail]> wrote:
> 
>> v5:
>> - Only update the perf sysfs groups (Dan)
>> - Remove unnecessary type cast (Jonathan)
>>
>> v4:
>> - Fix resetting of dpa_perf (Wonjae)
>> - Change cxl_qos_match() to return bool. (Jonathan)
>> - Remove unnecessary void * casting. (Jonathan)
>> - Replace open code with sysfs_update_groups() helper. (Jonathan)
>>
>> This series provides fixes to the memdev qos_class sysfs attributes. The
>> current code emits duplicate sysfs attribute under the same directory and
>> the ram qos_class clobbers the pmem qos_class. Move the attributes under
>> static definitions and allow the attributes to show up under ram and pmem
>> directory individually.
>>
>> The series also adds cxl_test support in order to allow CXL CLI add a unit
>> test for qos_class attributes.
> 
> I see Dan has this queued up already but fwiw (excluding patch 4 because
> I've not looked at the cxl-test stuff for a while).
> 
> For patches 1-3
> Reviewed-by: Jonathan Cameron <[e-mail]>

Thanks Jonathan!