mbox series

[v4,0/7] SRAT/CEDT fixes and updates

Message ID 20240424154846.2152750-1-rrichter@amd.com
Headers show
Series SRAT/CEDT fixes and updates | expand

Message

Robert Richter April 24, 2024, 3:48 p.m. UTC
Some fixes and updates for SRAT/CEDT parsing code. Patches can be
applied individually and are independent.

First patch fixes a page fault during boot. It should be marked
stable.

2nd patch reworks the code around numa_fill_memblks() (Dan's
suggestion).

Patches 3 to 5 remove architectural code no longer needed.

Patches 6 to 7 add diagnostic printouts for CEDT (can be dropped if
so).

Changelog:

v4:
 * updated SOB chains and desription (Alison, Dan)
 * added patch "x86/numa: Remove numa_fill_memblks() from sparsemem.h
   using __weak", please check note on authorship (Dan)
 * Reordered patches to move CEDT table printout as an option at the
   end (Dan)
 * split print table patch and added: "ACPI/NUMA: Add log messages for
   memory ranges found in CEDT" (Alison, Dan)

v3:
 * Rebased onto v6.9-rc1
 * Fixing x86 build error in sparsemem.h [Dan/Alison]
 * Added CEDT node info [Alison]
 * Use pr_debug() for table output [Dan]
 * Refactoring split in 3 patches [Dan]
 * Fixed performance regression introduced [kbot]
 * Fixed checkpatch issues [Dan]

Bases on v6.9-rc1.

Robert Richter (7):
  x86/numa: Fix SRAT lookup of CFMWS ranges with numa_fill_memblks()
  x86/numa: Remove numa_fill_memblks() from sparsemem.h using __weak
  ACPI/NUMA: Remove architecture dependent remainings
  ACPI/NUMA: Squash acpi_numa_slit_init() into acpi_parse_slit()
  ACPI/NUMA: Squash acpi_numa_memory_affinity_init() into
    acpi_parse_memory_affinity()
  ACPI/NUMA: Add log messages for memory ranges found in CEDT
  ACPI/NUMA: Print CXL Early Discovery Table (CEDT)

 arch/x86/include/asm/numa.h      |   1 +
 arch/x86/include/asm/sparsemem.h |   2 -
 arch/x86/mm/numa.c               |   4 +-
 drivers/acpi/numa/srat.c         | 203 +++++++++++++++++++++++--------
 include/linux/acpi.h             |   5 -
 include/linux/numa.h             |   7 --
 6 files changed, 155 insertions(+), 67 deletions(-)


base-commit: d37a823e8ac01a2f657eed7aed8ea7e515c5f147

Comments

Dan Williams April 24, 2024, 5:46 p.m. UTC | #1
Robert Richter wrote:
> Some fixes and updates for SRAT/CEDT parsing code. Patches can be
> applied individually and are independent.
> 
> First patch fixes a page fault during boot. It should be marked
> stable.
> 
> 2nd patch reworks the code around numa_fill_memblks() (Dan's
> suggestion).

Just squash these 2 together. The -stable maintainers continue to assert
that fixes should do the right thing by mainline mainline standards and
let the -stable backport process decide if a different change needs to
be made for older kernels. I see no benefit for tracking 2 changes for
how numa_fill_memblks() is defined.
Robert Richter April 25, 2024, 7:34 a.m. UTC | #2
On 24.04.24 10:46:44, Dan Williams wrote:
> Robert Richter wrote:
> > Some fixes and updates for SRAT/CEDT parsing code. Patches can be
> > applied individually and are independent.
> > 
> > First patch fixes a page fault during boot. It should be marked
> > stable.
> > 
> > 2nd patch reworks the code around numa_fill_memblks() (Dan's
> > suggestion).
> 
> Just squash these 2 together. The -stable maintainers continue to assert
> that fixes should do the right thing by mainline mainline standards and
> let the -stable backport process decide if a different change needs to
> be made for older kernels. I see no benefit for tracking 2 changes for
> how numa_fill_memblks() is defined.

Ok, will drop #1 in a v5.

Thanks,

-Robert