From patchwork Thu Aug 15 00:55:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kobayashi,Daisuke" X-Patchwork-Id: 13764328 Received: from esa3.hc1455-7.c3s2.iphmx.com (esa3.hc1455-7.c3s2.iphmx.com [207.54.90.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8AA1362 for ; Thu, 15 Aug 2024 00:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.54.90.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723683154; cv=none; b=uDVo6SGVUNhcsKEhVYNp1AUvAAHQONCMjSwAGN0N868YIZ//bZKc2DuORQpZICGcUXJ+wxa2ssfBrnPVkOTDHFhtzYbSeSXA17mBSHARjlGArvJrjWfvEXnbLROlGD+wLfSNuvZTvl8vXmmG2/etxtIIKmfEVT15sI6dACKlwIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723683154; c=relaxed/simple; bh=DOBMs16N3Y0L0lwWEUilJ9ABQWxp98Y9CQmNuk4XzEE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Aomrhj8u4SDSKyEOoUFxgXOqcW5TZvJDhzzNFdRat3wxncMk2J8Euc0lo8459VaFsahZjhn/wuJfREsE6WWACfW/97GdZt495FwxGzgXBDzOwSg9ncVhey7um4WQpIQXx9Y2YIOCIpWiWaXEzaTz52p9YGmzP4eBWlAw/2puUOg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fujitsu.com; spf=pass smtp.mailfrom=fujitsu.com; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b=ALRFHEWX; arc=none smtp.client-ip=207.54.90.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b="ALRFHEWX" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1723683152; x=1755219152; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=DOBMs16N3Y0L0lwWEUilJ9ABQWxp98Y9CQmNuk4XzEE=; b=ALRFHEWXAqsfa659rSzWUyfEtXqMYIp9lAajUaLHKPYuYYReeX0sd2Tt O7mNk2HQ1U5hxavgj2y7YqqLgpPTO7bCPCgxQf+86bUvH8i/sOunWxmu9 7JxmcJMEy/LCn4CIKPhLDiGx0F90d/TEXh+UjImPGELOvqMYxlx6r9QG6 YQlPX4k9ZzmeXhBqxL6eX9Zxc8Ipw6svvdtciREpFZHJBzAQQRp9uc02F QarqUiXJT40tNhwK4VQYkJxWc+mvzcTSwZL4SdO5Fguz45g8/K70Q9TMx PnN07qhm5ckZCukAQ4ytXuWHJP2Ry8nZrkB8UuqmwL7H9hPockBBJ+koZ g==; X-CSE-ConnectionGUID: wSArR7b0S++DzUJP6cjyzQ== X-CSE-MsgGUID: K59pG0iNSiqmxuZVO6zTZA== X-IronPort-AV: E=McAfee;i="6700,10204,11164"; a="170626618" X-IronPort-AV: E=Sophos;i="6.10,147,1719846000"; d="scan'208";a="170626618" Received: from unknown (HELO oym-r3.gw.nic.fujitsu.com) ([210.162.30.91]) by esa3.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2024 09:52:29 +0900 Received: from oym-m4.gw.nic.fujitsu.com (oym-nat-oym-m4.gw.nic.fujitsu.com [192.168.87.61]) by oym-r3.gw.nic.fujitsu.com (Postfix) with ESMTP id ADC3ECA1E1 for ; Thu, 15 Aug 2024 09:52:26 +0900 (JST) Received: from m3003.s.css.fujitsu.com (sqmail-3003.b.css.fujitsu.com [10.128.233.114]) by oym-m4.gw.nic.fujitsu.com (Postfix) with ESMTP id EEEA6D52B5 for ; Thu, 15 Aug 2024 09:52:25 +0900 (JST) Received: from cxl-test.. (unknown [10.118.236.45]) by m3003.s.css.fujitsu.com (Postfix) with ESMTP id A8B8F200536D; Thu, 15 Aug 2024 09:52:25 +0900 (JST) From: "Kobayashi,Daisuke" To: linux-cxl@vger.kernel.org, dan.j.williams@intel.com Cc: y-goto@fujitsu.com, mj@ucw.cz, "Kobayashi,Daisuke" Subject: [PATCH v16 0/2] Export cxl1.1 device link status register value to pci device sysfs. Date: Thu, 15 Aug 2024 09:55:08 +0900 Message-ID: <20240815005510.220835-1-kobayashi.da-06@fujitsu.com> X-Mailer: git-send-email 2.45.0 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 CXL devices are extensions of PCIe. Therefore, from CXL2.0 onwards, the link status can be output in the same way as traditional PCIe. However, unlike devices from CXL2.0 onwards, CXL1.1 requires a different method to obtain the link status from traditional PCIe. This is because the link status of the CXL1.1 device is not mapped in the configuration space (as per cxl3.0 specification 8.1). Instead, the configuration space containing the link status is mapped to the memory mapped register region (as per cxl3.0 specification 8.2, Table 8-18). Therefore, the current lspci has a problem where it does not display the link status of the CXL1.1 device. Solve these issues with sysfs attributes to export the status registers hidden in the RCRB. The procedure is as follows: First, obtain the RCRB address within the cxl driver, then access the configuration space. Next, output the link status information from the configuration space to sysfs. Ultimately, the expectation is that this sysfs file will be consumed by PCI user tools to utilize link status information. Changes v1[1] -> v2: - Modified to perform rcrb access within the CXL driver. - Added new attributes to the sysfs of the PCI device. - Output the link status information to the sysfs of the PCI device. - Retrieve information from sysfs as the source when displaying information in lspci. v2[2] -> v3: - Fix unnecessary initialization and wrong types (Bjohn). - Create a helper function for getting a PCIe capability offset (Bjohn). - Move platform-specific implementation to the lib directory in pciutils (Martin). v3[3] -> v4: - RCRB register values are read once and cached. - Added a new attribute to the sysfs of the PCI device. - Separate lspci implementation from this patch. v4[4] -> v5: - Use macros for bitwise operations - Fix RCRB access to use cxl_memdev v5[5] -> v6: - Add and use masks for RCRB register values v6[6] -> v7: - Fix comments on white space inline v7[7] -> v8: - Change the cache value to offset - Access memory map area in rcd_*_show() functions v8[8] -> v9: - Map the pcie cap in for all the time the driver is bound to the device. - Add mapping the pcie cap in cxl_rcd_component_reg_phys(). v9[9] -> v10: - Change a utility function for getting PCIe capability. - Fix tab alignment issue, error handling, and apply suggestions from Jonathan. v10[10] -> v11: - Add functions to have one function do only one thing. - Add a size parameter to utility function arguments and consolidated them into one. v11[11] -> v12: - Fix the error handling in cxl_pci_setup_regs(). - Fix and clean up some details. v12[12] -> v13: - Fix and clean up some details. v13[13] -> v14: - Fix and clean up some details. v14[14] -> v15: - Change dport lookup to be done only once. - Fix the visibility of cxl_rcrb_to_linkcap(). v15[15] -> v16: - Fix the port leak bug by introduce a new scope-based-free handler - Improve the variable names. [1] https://lore.kernel.org/linux-cxl/20231220050738.178481-1-kobayashi.da-06@fujitsu.com/ [2] https://lore.kernel.org/linux-cxl/20240227083313.87699-1-kobayashi.da-06@fujitsu.com/ [3] https://lore.kernel.org/linux-cxl/20240312080559.14904-1-kobayashi.da-06@fujitsu.com/ [4] https://lore.kernel.org/linux-cxl/20240409073528.13214-1-kobayashi.da-06@fujitsu.com/ [5] https://lore.kernel.org/linux-cxl/20240412070715.16160-1-kobayashi.da-06@fujitsu.com/ [6] https://lore.kernel.org/linux-cxl/20240424050102.26788-1-kobayashi.da-06@fujitsu.com/ [7] https://lore.kernel.org/linux-cxl/20240510073710.98953-1-kobayashi.da-06@fujitsu.com/ [8] https://lore.kernel.org/linux-cxl/20240606074814.5633-1-kobayashi.da-06@fujitsu.com/ [9] https://lore.kernel.org/linux-cxl/20240610082222.22772-1-kobayashi.da-06@fujitsu.com/ [10] https://lore.kernel.org/linux-cxl/20240611055254.61203-1-kobayashi.da-06@fujitsu.com/ [11] https://lore.kernel.org/linux-cxl/20240612075940.92500-1-kobayashi.da-06@fujitsu.com/ [12] https://lore.kernel.org/linux-cxl/20240614045611.58658-1-kobayashi.da-06@fujitsu.com/ [13] https://lore.kernel.org/linux-cxl/20240617043702.62028-1-kobayashi.da-06@fujitsu.com/ [14] https://lore.kernel.org/linux-cxl/20240618042941.96893-1-kobayashi.da-06@fujitsu.com/ [15] https://lore.kernel.org/linux-cxl/20240716042540.89639-1-kobayashi.da-06@fujitsu.com/ Kobayashi,Daisuke (2): cxl/core/regs: Add rcd_pcie_cap initialization cxl/pci: Add sysfs attribute for CXL 1.1 device link status drivers/cxl/core/core.h | 5 ++ drivers/cxl/core/regs.c | 56 +++++++++++++++++++++ drivers/cxl/cxl.h | 9 ++++ drivers/cxl/pci.c | 108 +++++++++++++++++++++++++++++++++++----- 4 files changed, 166 insertions(+), 12 deletions(-)