mbox series

[v2,0/4] Do not allow set-partition immediate mode

Message ID cover.1645817416.git.alison.schofield@intel.com
Headers show
Series Do not allow set-partition immediate mode | expand

Message

Alison Schofield Feb. 25, 2022, 8:30 p.m. UTC 
From: Alison Schofield <alison.schofield@intel.com>

The v1 to address this issue was a single patch [1] that inserted
a new immediate mode check in the send path where the payload was
available for examining. That was not in the 'validation' function.

Reviewer feedback led to refactoring the send path of userspace mailbox
commands so that validation work can all spawn from one place:
cxl_validate_cmd_from_user().

Hence this set:
Patches 1,2: Refactor existing code. 
Patch 3: Blocks the immediate mode of the set-partition command.
	 Original v1 patch updated per reviewer feedback.
Patch 4: Removes CXL_PMEM exclusive commands restriction.

Changes in v2:
- Refactor the send path of userspace mbox cmds. (Dan, Ben)
- Patch 3 commit log - update the need to block. (Dan)
- Return -EBUSY (not -EINVAL), when blocking immediate mode. (Ben)
- Remove unneeded cast of void (payload_in). (dan)
- s/u64/__le64 in struct cxl_mbox_set_partition_info. (Dan)

[1] https://lore.kernel.org/linux-cxl/20220103202100.784194-1-alison.schofield@intel.com/

Alison Schofield (4):
  cxl/mbox: Move cxl_mem_command construction to helper funcs
  cxl/mbox: Centralize the validation of user commands
  cxl/mbox: Block immediate mode in SET_PARTITION_INFO command
  cxl/pmem: Remove CXL SET_PARTITION_INFO from exclusive_cmds list

 drivers/cxl/core/mbox.c | 308 +++++++++++++++++++++++-----------------
 drivers/cxl/cxlmem.h    |   7 +
 drivers/cxl/pmem.c      |   1 -
 3 files changed, 184 insertions(+), 132 deletions(-)


base-commit: 3e9e1e72c0c24fcbeb8c96f4e886be138f61496f