From patchwork Wed Mar 30 01:30:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alison Schofield X-Patchwork-Id: 12795386 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4618C433FE for ; Wed, 30 Mar 2022 01:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234798AbiC3B3r (ORCPT ); Tue, 29 Mar 2022 21:29:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241610AbiC3B3q (ORCPT ); Tue, 29 Mar 2022 21:29:46 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0837DBBE0E for ; Tue, 29 Mar 2022 18:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648603682; x=1680139682; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Ru7IkgHcq2Rlpqdc67pMbPQSJFypPFxD33XNqyYEp5w=; b=gYcSUkj7bdLpsqImGuF66RV3IDWPBkSFXVi1a6NK0/WjilbG0GeaUuDV SXMmuiCfxIlDFg02DF2GUn32Yde3aw9NcLJvhdpZxjKWSJrAbRQjtGlWP yJD1igTuF0lT8BWUzHoniQe6pbBZ435NHWKA/iQjvEIEiQs7+26JnDONl SC5wqtfHXCVjqe1mHL9McWU/f5S5aQbb4SmSALdtgkQlqQCqAz225Bfzt lHylniTEbk+dWS65xIcJx8EgUTdF/qXMQNuPRADYKaomjgODucbsgGBcj mirTmoqekEbVNJgyOyWOvtbzAd0Eqlvx6UwMZ2sM29ph+7pxSXX5CU30q g==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="259391089" X-IronPort-AV: E=Sophos;i="5.90,221,1643702400"; d="scan'208";a="259391089" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 18:28:01 -0700 X-IronPort-AV: E=Sophos;i="5.90,221,1643702400"; d="scan'208";a="653449568" Received: from alison-desk.jf.intel.com (HELO localhost) ([10.54.74.41]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 18:28:01 -0700 From: alison.schofield@intel.com To: Ben Widawsky , Dan Williams , Ira Weiny , Vishal Verma Cc: Alison Schofield , linux-cxl@vger.kernel.org Subject: [PATCH v4 0/9] Do not allow set-partition immediate mode Date: Tue, 29 Mar 2022 18:30:15 -0700 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org From: Alison Schofield Blocking immediate mode in set-partition info triggered a refactoring of the send path of userspace mailbox commands. The v1 to address the issue was a single patch [1] that inserted a new immediate mode check in the send path where the payload was available for examining. That was not in a validation function. Revisions after v1 included the refactoring of the send path so that validation work all spawns from cxl_validate_cmd_from_user(). Patches 1-7: Refactor existing code so that all validation work can spawn from cxl_validate_cmd_from_user(). The movement intends to cleanly rip the work of building a mailbox command away from handle_mailbox_command_from_user() and give it to cxl_validate_cmd_from_user(). Patch 8: Blocks the immediate mode of the set-partition command. Patch 9: Removes CXL_PMEM exclusive commands restriction. [1]https://lore.kernel.org/linux-cxl/20220103202100.784194-1-alison.schofield@intel.com/ Changes in v4: (All from Jonathan's review - Thank-you Jonathan) - Add a blank line after return - Combine cxl_mem_command and info declaration and init. - Replace "rc =" with direct returns in cxl_validate_cmd_from_user() - Don't init and then overwrite out_size - Rm the 'refactor foreshadowing' goto & don't restore it later - Wordsmithing in Patch 4 commit log - Mv error path to be out of line, normal path inline. - Move kvfree()'s from handle_mbox...() to cxl_send_cmd() Patches 1,2,4,5,6,7,8: Added Jonathan Reviewed-by Tags. Patches 2,7,8,9: No code changes Changes in v3: - Split up the 'Centralize the validation...' patch into 6 pieces. Patch: cxl/mbox: Move cxl_mem_command construction to helper funcs - Safely initialize the cxl_mem_command structs. (Dan) - Remove unneeded memcpy (Dan) Patch: cxl/mbox: Block immediate mode in SET_PARTITION_INFO command - No Changes Patch: cxl/pmem: Remove CXL SET_PARTITION_INFO from exclusive_cmds list - No Changes Changes in v2: - Refactor the send path of userspace mbox cmds. (Dan, Ben) - Patch 3 commit log - update the need to block. (Dan) - Return -EBUSY (not -EINVAL), when blocking immediate mode. (Ben) - Remove unneeded cast of void (payload_in). (dan) - s/u64/__le64 in struct cxl_mbox_set_partition_info. (Dan) Alison Schofield (9): cxl/mbox: Move cxl_mem_command construction to helper funcs cxl/mbox: Move raw command warning to raw command validation cxl/mbox: Move build of user mailbox cmd to a helper function cxl/mbox: Construct a users cxl_mbox_cmd in the validation path cxl/mbox: Remove dependency on cxl_mem_command for a debug msg cxl/mbox: Make handle_mailbox_cmd_from_user() use a mbox param cxl/mbox: Move cxl_mem_command param to a local variable cxl/mbox: Block immediate mode in SET_PARTITION_INFO command cxl/pmem: Remove CXL SET_PARTITION_INFO from exclusive_cmds list drivers/cxl/core/mbox.c | 339 ++++++++++++++++++++++++---------------- drivers/cxl/cxlmem.h | 7 + drivers/cxl/pmem.c | 1 - 3 files changed, 211 insertions(+), 136 deletions(-) base-commit: 9b688fc651b9d2b633e8d959454670aba1c39162