From patchwork Mon Nov 28 04:15:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Wunner X-Patchwork-Id: 13057033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2D30C4321E for ; Mon, 28 Nov 2022 04:43:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbiK1EnQ (ORCPT ); Sun, 27 Nov 2022 23:43:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbiK1EnE (ORCPT ); Sun, 27 Nov 2022 23:43:04 -0500 X-Greylist: delayed 602 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 27 Nov 2022 20:43:03 PST Received: from mailout1.hostsharing.net (mailout1.hostsharing.net [IPv6:2a01:37:1000::53df:5fcc:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2065F12AA6; Sun, 27 Nov 2022 20:43:00 -0800 (PST) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by mailout1.hostsharing.net (Postfix) with ESMTPS id D1F13101920D9; Mon, 28 Nov 2022 05:25:49 +0100 (CET) Received: from localhost (unknown [89.246.108.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by h08.hostsharing.net (Postfix) with ESMTPSA id 9ACAB603E021; Mon, 28 Nov 2022 05:25:49 +0100 (CET) X-Mailbox-Line: From 7ced46eaf68bed71b6414a93ac41f26cfd54a991 Mon Sep 17 00:00:00 2001 Message-Id: From: Lukas Wunner Date: Mon, 28 Nov 2022 05:15:50 +0100 Subject: [PATCH 0/2] DOE WARN splat be gone To: Bjorn Helgaas , linux-pci@vger.kernel.org Cc: Gregory Price , Ira Weiny , Jonathan Cameron , Dan Williams , Alison Schofield , Vishal Verma , "Li, Ming" , linux-cxl@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org Here's my proposal to fix the DOE WARN splat reported by Gregory Price: One backportable oneliner to replace INIT_WORK() with INIT_WORK_ONSTACK() and one patch to change the API and thus fix the problem for good. So that's an alternative approach to Ira's. Please review and test. Thanks! Lukas Wunner (2): PCI/DOE: Silence WARN splat upon task submission PCI/DOE: Provide synchronous API drivers/cxl/core/pci.c | 58 +++++++------------- drivers/pci/doe.c | 114 +++++++++++++++++++++++++++++++++------- include/linux/pci-doe.h | 47 ++--------------- 3 files changed, 117 insertions(+), 102 deletions(-)