| Message ID | 165237926188.3832067.15441813087107623945.stgit@dwillia2-desk3.amr.corp.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cxl: Fix "mem_enable" handling | expand |
On Thu, 12 May 2022 11:14:21 -0700 Dan Williams <dan.j.williams@intel.com> wrote: > Media ready is asserted by the device independent of whether mem_enabled > was ever set. Drop this check to allow for dropping wait_for_media() in > favor of ->wait_media_ready(). > > Fixes: 8dd2bc0f8e02 ("cxl/mem: Add the cxl_mem driver") > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/mem.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c > index 401b0fbe21db..c2d9dadf4a2e 100644 > --- a/drivers/cxl/mem.c > +++ b/drivers/cxl/mem.c > @@ -27,12 +27,8 @@ > static int wait_for_media(struct cxl_memdev *cxlmd) > { > struct cxl_dev_state *cxlds = cxlmd->cxlds; > - struct cxl_endpoint_dvsec_info *info = &cxlds->info; > int rc; > > - if (!info->mem_enabled) > - return -EBUSY; > - > rc = cxlds->wait_media_ready(cxlds); > if (rc) > return rc; >
diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c index 401b0fbe21db..c2d9dadf4a2e 100644 --- a/drivers/cxl/mem.c +++ b/drivers/cxl/mem.c @@ -27,12 +27,8 @@ static int wait_for_media(struct cxl_memdev *cxlmd) { struct cxl_dev_state *cxlds = cxlmd->cxlds; - struct cxl_endpoint_dvsec_info *info = &cxlds->info; int rc; - if (!info->mem_enabled) - return -EBUSY; - rc = cxlds->wait_media_ready(cxlds); if (rc) return rc;
Media ready is asserted by the device independent of whether mem_enabled was ever set. Drop this check to allow for dropping wait_for_media() in favor of ->wait_media_ready(). Fixes: 8dd2bc0f8e02 ("cxl/mem: Add the cxl_mem driver") Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/cxl/mem.c | 4 ---- 1 file changed, 4 deletions(-)