diff mbox series

[ndctl,v2,01/18] ndctl/test: Move firmware-update.sh to the 'destructive' set

Message ID 167053488383.582963.12851797514973259163.stgit@dwillia2-xfh.jf.intel.com
State Accepted
Commit 865313b3eab71df2f45431eb5c80212771213532
Headers show
Series cxl-cli test and usability updates | expand

Commit Message

Dan Williams Dec. 8, 2022, 9:28 p.m. UTC
The firmware update test attempts a system-suspend test which may break
systems that have a broken driver, or otherwise are not prepared to support
suspend.

Link: https://github.com/pmem/ndctl/issues/221
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 test/meson.build |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alison Schofield Dec. 9, 2022, 5:13 p.m. UTC | #1
On Thu, Dec 08, 2022 at 01:28:03PM -0800, Dan Williams wrote:
> The firmware update test attempts a system-suspend test which may break
> systems that have a broken driver, or otherwise are not prepared to support
> suspend.
> 

Reviewed-by: Alison Schofield <alison.schofield@intel.com>

> Link: https://github.com/pmem/ndctl/issues/221
> Reported-by: Yi Zhang <yi.zhang@redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  test/meson.build |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/meson.build b/test/meson.build
> index 5953c286d13f..c31d8eac66c5 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -170,7 +170,6 @@ tests = [
>    [ 'btt-errors.sh',          btt_errors,	  'ndctl' ],
>    [ 'hugetlb',                hugetlb,		  'ndctl' ],
>    [ 'btt-pad-compat.sh',      btt_pad_compat,	  'ndctl' ],
> -  [ 'firmware-update.sh',     firmware_update,	  'ndctl' ],
>    [ 'ack-shutdown-count-set', ack_shutdown_count, 'ndctl' ],
>    [ 'rescan-partitions.sh',   rescan_partitions,  'ndctl' ],
>    [ 'inject-smart.sh',        inject_smart,	  'ndctl' ],
> @@ -196,6 +195,7 @@ if get_option('destructive').enabled()
>    mmap_test = find_program('mmap.sh')
>  
>    tests += [
> +    [ 'firmware-update.sh',     firmware_update,	  'ndctl' ],
>      [ 'pmem-ns',           pmem_ns,	   'ndctl' ],
>      [ 'sub-section.sh',    sub_section,	   'dax'   ],
>      [ 'dax-dev',           dax_dev,	   'dax'   ],
>
diff mbox series

Patch

diff --git a/test/meson.build b/test/meson.build
index 5953c286d13f..c31d8eac66c5 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -170,7 +170,6 @@  tests = [
   [ 'btt-errors.sh',          btt_errors,	  'ndctl' ],
   [ 'hugetlb',                hugetlb,		  'ndctl' ],
   [ 'btt-pad-compat.sh',      btt_pad_compat,	  'ndctl' ],
-  [ 'firmware-update.sh',     firmware_update,	  'ndctl' ],
   [ 'ack-shutdown-count-set', ack_shutdown_count, 'ndctl' ],
   [ 'rescan-partitions.sh',   rescan_partitions,  'ndctl' ],
   [ 'inject-smart.sh',        inject_smart,	  'ndctl' ],
@@ -196,6 +195,7 @@  if get_option('destructive').enabled()
   mmap_test = find_program('mmap.sh')
 
   tests += [
+    [ 'firmware-update.sh',     firmware_update,	  'ndctl' ],
     [ 'pmem-ns',           pmem_ns,	   'ndctl' ],
     [ 'sub-section.sh',    sub_section,	   'dax'   ],
     [ 'dax-dev',           dax_dev,	   'dax'   ],