| Message ID | 167053490140.582963.14276565576884840344.stgit@dwillia2-xfh.jf.intel.com |
|---|---|
| State | Accepted |
| Commit | 4b9bab833280d936d0806ed08ab4db00e7c6c0b8 |
| Headers | show |
| Series | cxl-cli test and usability updates | expand |
On Thu, Dec 08, 2022 at 01:28:21PM -0800, Dan Williams wrote: > Copy the approach taken in the kernel via: > > commit 781121a7f6d1 ("clang-format: Fix space after for_each macros") On a related note - 'cxl_mapping_foreach' seems to be missing from .clang-format. Perhaps it is in another patch I haven't seen yet. This patch - Reviewed-by: Alison Schofield <alison.schofield@intel.com> > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- > .clang-format | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.clang-format b/.clang-format > index f372823c3248..448b7e7211ae 100644 > --- a/.clang-format > +++ b/.clang-format > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > # > -# clang-format configuration file. Intended for clang-format >= 6. > +# clang-format configuration file. Intended for clang-format >= 11. > # Copied from Linux's .clang-format > # > # For more information, see: > @@ -157,7 +157,7 @@ SpaceAfterTemplateKeyword: true > SpaceBeforeAssignmentOperators: true > SpaceBeforeCtorInitializerColon: true > SpaceBeforeInheritanceColon: true > -SpaceBeforeParens: ControlStatements > +SpaceBeforeParens: ControlStatementsExceptForEachMacros > SpaceBeforeRangeBasedForLoopColon: true > SpaceInEmptyParentheses: false > SpacesBeforeTrailingComments: 1 >
On Fri, 2022-12-09 at 09:22 -0800, Alison Schofield wrote: > On Thu, Dec 08, 2022 at 01:28:21PM -0800, Dan Williams wrote: > > Copy the approach taken in the kernel via: > > > > commit 781121a7f6d1 ("clang-format: Fix space after for_each > > macros") > > On a related note - 'cxl_mapping_foreach' seems to be missing from > .clang-format. Perhaps it is in another patch I haven't seen yet. Ah good catch - I think that's my miss - I'll send out a patch for that separately. > > This patch - > Reviewed-by: Alison Schofield <alison.schofield@intel.com> > > > > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > > --- > > .clang-format | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/.clang-format b/.clang-format > > index f372823c3248..448b7e7211ae 100644 > > --- a/.clang-format > > +++ b/.clang-format > > @@ -1,6 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0 > > # > > -# clang-format configuration file. Intended for clang-format >= 6. > > +# clang-format configuration file. Intended for clang-format >= 11. > > # Copied from Linux's .clang-format > > # > > # For more information, see: > > @@ -157,7 +157,7 @@ SpaceAfterTemplateKeyword: true > > SpaceBeforeAssignmentOperators: true > > SpaceBeforeCtorInitializerColon: true > > SpaceBeforeInheritanceColon: true > > -SpaceBeforeParens: ControlStatements > > +SpaceBeforeParens: ControlStatementsExceptForEachMacros > > SpaceBeforeRangeBasedForLoopColon: true > > SpaceInEmptyParentheses: false > > SpacesBeforeTrailingComments: 1 > >
diff --git a/.clang-format b/.clang-format index f372823c3248..448b7e7211ae 100644 --- a/.clang-format +++ b/.clang-format @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 # -# clang-format configuration file. Intended for clang-format >= 6. +# clang-format configuration file. Intended for clang-format >= 11. # Copied from Linux's .clang-format # # For more information, see: @@ -157,7 +157,7 @@ SpaceAfterTemplateKeyword: true SpaceBeforeAssignmentOperators: true SpaceBeforeCtorInitializerColon: true SpaceBeforeInheritanceColon: true -SpaceBeforeParens: ControlStatements +SpaceBeforeParens: ControlStatementsExceptForEachMacros SpaceBeforeRangeBasedForLoopColon: true SpaceInEmptyParentheses: false SpacesBeforeTrailingComments: 1
Copy the approach taken in the kernel via: commit 781121a7f6d1 ("clang-format: Fix space after for_each macros") Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- .clang-format | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)