diff mbox series

[ndctl,v2,15/18] cxl/Documentation: Fix whitespace typos in create-region man page

Message ID 167053496662.582963.12739035781728195815.stgit@dwillia2-xfh.jf.intel.com
State Accepted
Commit bdf0cc04b8b57049445135f7fdfb46231a6fc2d7
Headers show
Series cxl-cli test and usability updates | expand

Commit Message

Dan Williams Dec. 8, 2022, 9:29 p.m. UTC 
---
 Documentation/cxl/cxl-create-region.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alison Schofield Dec. 9, 2022, 5:33 p.m. UTC | #1 
On Thu, Dec 08, 2022 at 01:29:26PM -0800, Dan Williams wrote:

Missing SOB and commit log

The diff - 
Reviewed-by: Alison Schofield <alison.schofield@intel.com>

> 
> ---
>  Documentation/cxl/cxl-create-region.txt |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/cxl/cxl-create-region.txt b/Documentation/cxl/cxl-create-region.txt
> index 6b740d5b8d96..e0e6818cfdd1 100644
> --- a/Documentation/cxl/cxl-create-region.txt
> +++ b/Documentation/cxl/cxl-create-region.txt
> @@ -28,7 +28,7 @@ be emitted on stderr.
>  EXAMPLE
>  -------
>  ----
> -#cxl create - region - m - d decoder0 .1 - w 2 - g 1024 mem0 mem1
> +#cxl create-region -m -d decoder0.1 -w 2 -g 1024 mem0 mem1
>  {
>    "region":"region0",
>    "resource":"0xc90000000",
>
Dan Williams Dec. 9, 2022, 6:06 p.m. UTC | #2 
Alison Schofield wrote:
> On Thu, Dec 08, 2022 at 01:29:26PM -0800, Dan Williams wrote:
> 
> Missing SOB and commit log

Whoops, moved too fast and broke things.

Vishal, feel free to add:

---
The 'create-region' man page had some typos when it was first created.
Clean them up per syntax expectations.

Fixes: 21b089025178 ("cxl: add a 'create-region' command")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

...or let me know if you want a resend.
Verma, Vishal L Dec. 13, 2022, 9:17 p.m. UTC | #3 
On Fri, 2022-12-09 at 10:06 -0800, Dan Williams wrote:
> Alison Schofield wrote:
> > On Thu, Dec 08, 2022 at 01:29:26PM -0800, Dan Williams wrote:
> > 
> > Missing SOB and commit log
> 
> Whoops, moved too fast and broke things.
> 
> Vishal, feel free to add:

No problem, done. Patch 7 was missing these too, but I've fixed that up
as well. This series is now in pushed to pending.

> 
> ---
> The 'create-region' man page had some typos when it was first created.
> Clean them up per syntax expectations.
> 
> Fixes: 21b089025178 ("cxl: add a 'create-region' command")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> 
> ...or let me know if you want a resend.
diff mbox series

Patch

diff --git a/Documentation/cxl/cxl-create-region.txt b/Documentation/cxl/cxl-create-region.txt
index 6b740d5b8d96..e0e6818cfdd1 100644
--- a/Documentation/cxl/cxl-create-region.txt
+++ b/Documentation/cxl/cxl-create-region.txt
@@ -28,7 +28,7 @@  be emitted on stderr.
 EXAMPLE
 -------
 ----
-#cxl create - region - m - d decoder0 .1 - w 2 - g 1024 mem0 mem1
+#cxl create-region -m -d decoder0.1 -w 2 -g 1024 mem0 mem1
 {
   "region":"region0",
   "resource":"0xc90000000",