| Message ID | 168357887947.2756219.6022306227580486103.stgit@djiang5-mobl3 |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cxl: Add support for QTG ID retrieval for CXL subsystem | expand |
On Mon, 08 May 2023 13:47:59 -0700 Dave Jiang <dave.jiang@intel.com> wrote: > CDAT data is only valid after the media is ready. Move read_cdat_data() to > after cxl_awai_media_read() is successful. await > > Signed-off-by: Dave Jiang <dave.jiang@intel.com> No fixes tag? Plus move it to the top of the series with the other two fixes. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/port.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c > index 0bdb9d73a389..1d55c460e1ab 100644 > --- a/drivers/cxl/port.c > +++ b/drivers/cxl/port.c > @@ -162,9 +162,6 @@ static int cxl_endpoint_port_probe(struct cxl_port *port) > if (IS_ERR(cxlhdm)) > return PTR_ERR(cxlhdm); > > - /* Cache the data early to ensure is_visible() works */ > - read_cdat_data(port); > - > get_device(&cxlmd->dev); > rc = devm_add_action_or_reset(&port->dev, schedule_detach, cxlmd); > if (rc) > @@ -180,6 +177,9 @@ static int cxl_endpoint_port_probe(struct cxl_port *port) > return rc; > } > > + /* Cache the data early to ensure is_visible() works */ > + read_cdat_data(port); > + > rc = cxl_dev_state_identify(cxlds); > if (rc) > return rc; > >
diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c index 0bdb9d73a389..1d55c460e1ab 100644 --- a/drivers/cxl/port.c +++ b/drivers/cxl/port.c @@ -162,9 +162,6 @@ static int cxl_endpoint_port_probe(struct cxl_port *port) if (IS_ERR(cxlhdm)) return PTR_ERR(cxlhdm); - /* Cache the data early to ensure is_visible() works */ - read_cdat_data(port); - get_device(&cxlmd->dev); rc = devm_add_action_or_reset(&port->dev, schedule_detach, cxlmd); if (rc) @@ -180,6 +177,9 @@ static int cxl_endpoint_port_probe(struct cxl_port *port) return rc; } + /* Cache the data early to ensure is_visible() works */ + read_cdat_data(port); + rc = cxl_dev_state_identify(cxlds); if (rc) return rc;
CDAT data is only valid after the media is ready. Move read_cdat_data() to after cxl_awai_media_read() is successful. Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- drivers/cxl/port.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)