From patchwork Fri Feb 19 02:03:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Verma, Vishal L" X-Patchwork-Id: 12188271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DCAC433E0 for ; Fri, 19 Feb 2021 02:05:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 227CB64ECE for ; Fri, 19 Feb 2021 02:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbhBSCFH (ORCPT ); Thu, 18 Feb 2021 21:05:07 -0500 Received: from mga12.intel.com ([192.55.52.136]:50646 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229474AbhBSCFG (ORCPT ); Thu, 18 Feb 2021 21:05:06 -0500 IronPort-SDR: JV23nzRAhDvaAMJhQQNo5s4MxwjIIcP5KzzCxnCXezJblfKTPkkQOKD9M2dIIsBVNg9eNAEwRX h3nE+5QRxIzw== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="162854720" X-IronPort-AV: E=Sophos;i="5.81,187,1610438400"; d="scan'208";a="162854720" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2021 18:03:54 -0800 IronPort-SDR: yE4hbpsazOW2dDW3Kyx4/2Ey5+rOD+a6yEzkMov3VVFV+jzB5fM9nKj2pCIvYwsiCsjmRWtKBD SCPQBFjK6N/A== X-IronPort-AV: E=Sophos;i="5.81,187,1610438400"; d="scan'208";a="513509666" Received: from jnavar1-mobl4.amr.corp.intel.com (HELO omniknight.intel.com) ([10.213.167.18]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2021 18:03:53 -0800 From: Vishal Verma To: Cc: , Ben Widawsky , Dan Williams , Vishal Verma Subject: [ndctl PATCH v2 08/13] libcxl: add GET_HEALTH_INFO mailbox command and accessors Date: Thu, 18 Feb 2021 19:03:26 -0700 Message-Id: <20210219020331.725687-9-vishal.l.verma@intel.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210219020331.725687-1-vishal.l.verma@intel.com> References: <20210219020331.725687-1-vishal.l.verma@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org Add libcxl APIs to create a new GET_HEALTH_INFO mailbox command, the command output data structure (privately), and accessor APIs to return the different fields in the health info output. Signed-off-by: Vishal Verma --- cxl/lib/private.h | 11 +++++++++ cxl/lib/libcxl.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++ cxl/libcxl.h | 9 +++++++ cxl/lib/libcxl.sym | 9 +++++++ 4 files changed, 90 insertions(+) diff --git a/cxl/lib/private.h b/cxl/lib/private.h index 3273f21..2232f4c 100644 --- a/cxl/lib/private.h +++ b/cxl/lib/private.h @@ -73,6 +73,17 @@ struct cxl_cmd_identify { u8 qos_telemetry_caps; } __attribute__((packed)); +struct cxl_cmd_get_health_info { + u8 health_status; + u8 media_status; + u8 ext_status; + u8 life_used; + le16 temperature; + le32 dirty_shutdowns; + le32 volatile_errors; + le32 pmem_errors; +} __attribute__((packed)); + static inline int check_kmod(struct kmod_ctx *kmod_ctx) { return kmod_ctx ? 0 : -ENXIO; diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c index 4751cba..d595d36 100644 --- a/cxl/lib/libcxl.c +++ b/cxl/lib/libcxl.c @@ -678,6 +678,67 @@ CXL_EXPORT const char *cxl_cmd_get_devname(struct cxl_cmd *cmd) return cxl_memdev_get_devname(cmd->memdev); } +#define cmd_get_int(cmd, n, N, field) \ +do { \ + struct cxl_cmd_##n *c = (void *)cmd->send_cmd->out.payload; \ + if (cmd->send_cmd->id != CXL_MEM_COMMAND_ID_##N) \ + return EINVAL; \ + if (cmd->status < 0) \ + return cmd->status; \ + return le32_to_cpu(c->field); \ +} while(0); + +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_get_health_info( + struct cxl_memdev *memdev) +{ + return cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_GET_HEALTH_INFO); +} + +#define cmd_health_get_int(c, f) \ +do { \ + cmd_get_int(c, get_health_info, GET_HEALTH_INFO, f); \ +} while (0); + +CXL_EXPORT int cxl_cmd_get_health_info_get_health_status(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, health_status); +} + +CXL_EXPORT int cxl_cmd_get_health_info_get_media_status(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, media_status); +} + +CXL_EXPORT int cxl_cmd_get_health_info_get_ext_status(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, ext_status); +} + +CXL_EXPORT int cxl_cmd_get_health_info_get_life_used(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, life_used); +} + +CXL_EXPORT int cxl_cmd_get_health_info_get_temperature(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, temperature); +} + +CXL_EXPORT int cxl_cmd_get_health_info_get_dirty_shutdowns(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, dirty_shutdowns); +} + +CXL_EXPORT int cxl_cmd_get_health_info_get_volatile_errors(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, volatile_errors); +} + +CXL_EXPORT int cxl_cmd_get_health_info_get_pmem_errors(struct cxl_cmd *cmd) +{ + cmd_health_get_int(cmd, pmem_errors); +} + CXL_EXPORT struct cxl_cmd *cxl_cmd_new_identify(struct cxl_memdev *memdev) { return cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_IDENTIFY); diff --git a/cxl/libcxl.h b/cxl/libcxl.h index 9ed8c83..56ae4af 100644 --- a/cxl/libcxl.h +++ b/cxl/libcxl.h @@ -62,6 +62,15 @@ struct cxl_cmd *cxl_cmd_new_identify(struct cxl_memdev *memdev); int cxl_cmd_identify_get_fw_rev(struct cxl_cmd *cmd, char *fw_rev, int fw_len); unsigned long long cxl_cmd_identify_get_partition_align(struct cxl_cmd *cmd); unsigned int cxl_cmd_identify_get_lsa_size(struct cxl_cmd *cmd); +struct cxl_cmd *cxl_cmd_new_get_health_info(struct cxl_memdev *memdev); +int cxl_cmd_get_health_info_get_health_status(struct cxl_cmd *cmd); +int cxl_cmd_get_health_info_get_media_status(struct cxl_cmd *cmd); +int cxl_cmd_get_health_info_get_ext_status(struct cxl_cmd *cmd); +int cxl_cmd_get_health_info_get_life_used(struct cxl_cmd *cmd); +int cxl_cmd_get_health_info_get_temperature(struct cxl_cmd *cmd); +int cxl_cmd_get_health_info_get_dirty_shutdowns(struct cxl_cmd *cmd); +int cxl_cmd_get_health_info_get_volatile_errors(struct cxl_cmd *cmd); +int cxl_cmd_get_health_info_get_pmem_errors(struct cxl_cmd *cmd); #ifdef __cplusplus } /* extern "C" */ diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym index d6aa0b2..e00443d 100644 --- a/cxl/lib/libcxl.sym +++ b/cxl/lib/libcxl.sym @@ -43,4 +43,13 @@ global: cxl_cmd_identify_get_fw_rev; cxl_cmd_identify_get_partition_align; cxl_cmd_identify_get_lsa_size; + cxl_cmd_new_get_health_info; + cxl_cmd_get_health_info_get_health_status; + cxl_cmd_get_health_info_get_media_status; + cxl_cmd_get_health_info_get_ext_status; + cxl_cmd_get_health_info_get_life_used; + cxl_cmd_get_health_info_get_temperature; + cxl_cmd_get_health_info_get_dirty_shutdowns; + cxl_cmd_get_health_info_get_volatile_errors; + cxl_cmd_get_health_info_get_pmem_errors; } LIBCXL_2;