| Message ID | 20210830171726.2342558-2-ben.widawsky@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] cxl: Fixed defined but not used warnings | expand |
On Mon, Aug 30, 2021 at 10:17 AM Ben Widawsky <ben.widawsky@intel.com> wrote: > > Fixed "Excess function parameter" warnings generated by the CHECK stage > of build. > I'll add the: Fixes: bd0964c858ec ("cxl/mbox: Move mailbox and other non-PCI specific infrastructure to the core") ...but otherwise looks good. > Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> > --- > drivers/cxl/core/mbox.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 48a07cf2deb4..1b3335f5ed59 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -640,10 +640,6 @@ EXPORT_SYMBOL_GPL(cxl_mem_enumerate_cmds); > /** > * cxl_mem_get_partition_info - Get partition info > * @cxlm: The device to act on > - * @active_volatile_bytes: returned active volatile capacity; in bytes > - * @active_persistent_bytes: returned active persistent capacity; in bytes > - * @next_volatile_bytes: return next volatile capacity; in bytes > - * @next_persistent_bytes: return next persistent capacity; in bytes > * > * Retrieve the current partition info for the device specified. The active > * values are the current capacity in bytes. If not 0, the 'next' values are > -- > 2.33.0 >
On Wed, Sep 1, 2021 at 12:15 PM Dan Williams <dan.j.williams@intel.com> wrote: > > On Mon, Aug 30, 2021 at 10:17 AM Ben Widawsky <ben.widawsky@intel.com> wrote: > > > > Fixed "Excess function parameter" warnings generated by the CHECK stage > > of build. > > > > I'll add the: > > Fixes: bd0964c858ec ("cxl/mbox: Move mailbox and other non-PCI > specific infrastructure to the core") > > ...but otherwise looks good. So this collided with Jonathan's wider comment to split out some of the changes from the "cxl/mbox: Move mailbox and other non-PCI specific infrastructure to the core" into precursor patches. So I ended up folding this change into a bigger cleanup of cxl_mem_get_partition_info(), but I'll add a Reported-by tag for my miss on the doc warning.
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 48a07cf2deb4..1b3335f5ed59 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -640,10 +640,6 @@ EXPORT_SYMBOL_GPL(cxl_mem_enumerate_cmds); /** * cxl_mem_get_partition_info - Get partition info * @cxlm: The device to act on - * @active_volatile_bytes: returned active volatile capacity; in bytes - * @active_persistent_bytes: returned active persistent capacity; in bytes - * @next_volatile_bytes: return next volatile capacity; in bytes - * @next_persistent_bytes: return next persistent capacity; in bytes * * Retrieve the current partition info for the device specified. The active * values are the current capacity in bytes. If not 0, the 'next' values are
Fixed "Excess function parameter" warnings generated by the CHECK stage of build. Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> --- drivers/cxl/core/mbox.c | 4 ---- 1 file changed, 4 deletions(-)