| Message ID | 20211007082139.3088615-9-vishal.l.verma@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initial CXL support | expand |
On Thu, Oct 7, 2021 at 1:22 AM Vishal Verma <vishal.l.verma@intel.com> wrote: > > Add a command allocator and accessor APIs for the 'GET_LSA' mailbox > command. > > Cc: Ben Widawsky <ben.widawsky@intel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > --- > cxl/lib/private.h | 5 +++++ > cxl/lib/libcxl.c | 36 ++++++++++++++++++++++++++++++++++++ > cxl/libcxl.h | 7 +++---- > cxl/lib/libcxl.sym | 4 ++-- > 4 files changed, 46 insertions(+), 6 deletions(-) > > diff --git a/cxl/lib/private.h b/cxl/lib/private.h > index f76b518..9c6317b 100644 > --- a/cxl/lib/private.h > +++ b/cxl/lib/private.h > @@ -73,6 +73,11 @@ struct cxl_cmd_identify { > u8 qos_telemetry_caps; > } __attribute__((packed)); > > +struct cxl_cmd_get_lsa_in { > + le32 offset; > + le32 length; > +} __attribute__((packed)); > + > struct cxl_cmd_get_health_info { > u8 health_status; > u8 media_status; > diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c > index 413be9c..33cc462 100644 > --- a/cxl/lib/libcxl.c > +++ b/cxl/lib/libcxl.c > @@ -1028,6 +1028,42 @@ CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev, > return cmd; > } > > +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_read_label(struct cxl_memdev *memdev, > + unsigned int offset, unsigned int length) > +{ > + struct cxl_cmd_get_lsa_in *get_lsa; > + struct cxl_cmd *cmd; > + > + cmd = cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_GET_LSA); > + if (!cmd) > + return NULL; > + > + get_lsa = (void *)cmd->send_cmd->in.payload; Any reason that @payload is not already a 'void *' to avoid this casting? Other than that this looks good to me. You can add: Reviewed-by: Dan Williams <dan.j.williams@intel.com>
On Thu, 2021-10-14 at 09:35 -0700, Dan Williams wrote: > On Thu, Oct 7, 2021 at 1:22 AM Vishal Verma <vishal.l.verma@intel.com> wrote: > > > > Add a command allocator and accessor APIs for the 'GET_LSA' mailbox > > command. > > > > Cc: Ben Widawsky <ben.widawsky@intel.com> > > Cc: Dan Williams <dan.j.williams@intel.com> > > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > > --- > > cxl/lib/private.h | 5 +++++ > > cxl/lib/libcxl.c | 36 ++++++++++++++++++++++++++++++++++++ > > cxl/libcxl.h | 7 +++---- > > cxl/lib/libcxl.sym | 4 ++-- > > 4 files changed, 46 insertions(+), 6 deletions(-) > > > > diff --git a/cxl/lib/private.h b/cxl/lib/private.h > > index f76b518..9c6317b 100644 > > --- a/cxl/lib/private.h > > +++ b/cxl/lib/private.h > > @@ -73,6 +73,11 @@ struct cxl_cmd_identify { > > u8 qos_telemetry_caps; > > } __attribute__((packed)); > > > > +struct cxl_cmd_get_lsa_in { > > + le32 offset; > > + le32 length; > > +} __attribute__((packed)); > > + > > struct cxl_cmd_get_health_info { > > u8 health_status; > > u8 media_status; > > diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c > > index 413be9c..33cc462 100644 > > --- a/cxl/lib/libcxl.c > > +++ b/cxl/lib/libcxl.c > > @@ -1028,6 +1028,42 @@ CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev, > > return cmd; > > } > > > > +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_read_label(struct cxl_memdev *memdev, > > + unsigned int offset, unsigned int length) > > +{ > > + struct cxl_cmd_get_lsa_in *get_lsa; > > + struct cxl_cmd *cmd; > > + > > + cmd = cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_GET_LSA); > > + if (!cmd) > > + return NULL; > > + > > + get_lsa = (void *)cmd->send_cmd->in.payload; > > Any reason that @payload is not already a 'void *' to avoid this casting? The send_cmd is part of the uapi which defined it as __u64. > > Other than that this looks good to me. > > You can add: > > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
On Thu, Oct 14, 2021 at 1:06 PM Verma, Vishal L <vishal.l.verma@intel.com> wrote: > > On Thu, 2021-10-14 at 09:35 -0700, Dan Williams wrote: > > On Thu, Oct 7, 2021 at 1:22 AM Vishal Verma <vishal.l.verma@intel.com> wrote: > > > > > > Add a command allocator and accessor APIs for the 'GET_LSA' mailbox > > > command. > > > > > > Cc: Ben Widawsky <ben.widawsky@intel.com> > > > Cc: Dan Williams <dan.j.williams@intel.com> > > > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > > > --- > > > cxl/lib/private.h | 5 +++++ > > > cxl/lib/libcxl.c | 36 ++++++++++++++++++++++++++++++++++++ > > > cxl/libcxl.h | 7 +++---- > > > cxl/lib/libcxl.sym | 4 ++-- > > > 4 files changed, 46 insertions(+), 6 deletions(-) > > > > > > diff --git a/cxl/lib/private.h b/cxl/lib/private.h > > > index f76b518..9c6317b 100644 > > > --- a/cxl/lib/private.h > > > +++ b/cxl/lib/private.h > > > @@ -73,6 +73,11 @@ struct cxl_cmd_identify { > > > u8 qos_telemetry_caps; > > > } __attribute__((packed)); > > > > > > +struct cxl_cmd_get_lsa_in { > > > + le32 offset; > > > + le32 length; > > > +} __attribute__((packed)); > > > + > > > struct cxl_cmd_get_health_info { > > > u8 health_status; > > > u8 media_status; > > > diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c > > > index 413be9c..33cc462 100644 > > > --- a/cxl/lib/libcxl.c > > > +++ b/cxl/lib/libcxl.c > > > @@ -1028,6 +1028,42 @@ CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev, > > > return cmd; > > > } > > > > > > +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_read_label(struct cxl_memdev *memdev, > > > + unsigned int offset, unsigned int length) > > > +{ > > > + struct cxl_cmd_get_lsa_in *get_lsa; > > > + struct cxl_cmd *cmd; > > > + > > > + cmd = cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_GET_LSA); > > > + if (!cmd) > > > + return NULL; > > > + > > > + get_lsa = (void *)cmd->send_cmd->in.payload; > > > > Any reason that @payload is not already a 'void *' to avoid this casting? > > The send_cmd is part of the uapi which defined it as __u64. Ah, got it.
diff --git a/cxl/lib/private.h b/cxl/lib/private.h index f76b518..9c6317b 100644 --- a/cxl/lib/private.h +++ b/cxl/lib/private.h @@ -73,6 +73,11 @@ struct cxl_cmd_identify { u8 qos_telemetry_caps; } __attribute__((packed)); +struct cxl_cmd_get_lsa_in { + le32 offset; + le32 length; +} __attribute__((packed)); + struct cxl_cmd_get_health_info { u8 health_status; u8 media_status; diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c index 413be9c..33cc462 100644 --- a/cxl/lib/libcxl.c +++ b/cxl/lib/libcxl.c @@ -1028,6 +1028,42 @@ CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev, return cmd; } +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_read_label(struct cxl_memdev *memdev, + unsigned int offset, unsigned int length) +{ + struct cxl_cmd_get_lsa_in *get_lsa; + struct cxl_cmd *cmd; + + cmd = cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_GET_LSA); + if (!cmd) + return NULL; + + get_lsa = (void *)cmd->send_cmd->in.payload; + get_lsa->offset = cpu_to_le32(offset); + get_lsa->length = cpu_to_le32(length); + return cmd; +} + +CXL_EXPORT ssize_t cxl_cmd_read_label_get_payload(struct cxl_cmd *cmd, + void *buf, unsigned int length) +{ + struct cxl_cmd_get_lsa_in *get_lsa; + void *payload; + int rc; + + rc = cxl_cmd_validate_status(cmd, CXL_MEM_COMMAND_ID_GET_LSA); + if (rc) + return rc; + + get_lsa = (void *)cmd->send_cmd->in.payload; + if (length > le32_to_cpu(get_lsa->length)) + return -EINVAL; + + payload = (void *)cmd->send_cmd->out.payload; + memcpy(buf, payload, length); + return length; +} + CXL_EXPORT int cxl_cmd_submit(struct cxl_cmd *cmd) { struct cxl_memdev *memdev = cmd->memdev; diff --git a/cxl/libcxl.h b/cxl/libcxl.h index 68f5bc2..7408745 100644 --- a/cxl/libcxl.h +++ b/cxl/libcxl.h @@ -95,11 +95,10 @@ int cxl_cmd_health_info_get_temperature(struct cxl_cmd *cmd); int cxl_cmd_health_info_get_dirty_shutdowns(struct cxl_cmd *cmd); int cxl_cmd_health_info_get_volatile_errors(struct cxl_cmd *cmd); int cxl_cmd_health_info_get_pmem_errors(struct cxl_cmd *cmd); -struct cxl_cmd *cxl_cmd_new_get_lsa(struct cxl_memdev *memdev, +struct cxl_cmd *cxl_cmd_new_read_label(struct cxl_memdev *memdev, unsigned int offset, unsigned int length); -void *cxl_cmd_get_lsa_get_payload(struct cxl_cmd *cmd); -struct cxl_cmd *cxl_cmd_new_set_lsa(struct cxl_memdev *memdev, - void *buf, unsigned int offset, unsigned int length); +ssize_t cxl_cmd_read_label_get_payload(struct cxl_cmd *cmd, void *buf, + unsigned int length); #ifdef __cplusplus } /* extern "C" */ diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym index b0a3047..1b608d8 100644 --- a/cxl/lib/libcxl.sym +++ b/cxl/lib/libcxl.sym @@ -72,6 +72,6 @@ global: cxl_cmd_health_info_get_dirty_shutdowns; cxl_cmd_health_info_get_volatile_errors; cxl_cmd_health_info_get_pmem_errors; - cxl_cmd_new_get_lsa; - cxl_cmd_get_lsa_get_payload; + cxl_cmd_new_read_label; + cxl_cmd_read_label_get_payload; } LIBCXL_2;
Add a command allocator and accessor APIs for the 'GET_LSA' mailbox command. Cc: Ben Widawsky <ben.widawsky@intel.com> Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- cxl/lib/private.h | 5 +++++ cxl/lib/libcxl.c | 36 ++++++++++++++++++++++++++++++++++++ cxl/libcxl.h | 7 +++---- cxl/lib/libcxl.sym | 4 ++-- 4 files changed, 46 insertions(+), 6 deletions(-)