| Message ID | 20211022183709.1199701-5-ben.widawsky@intel.com |
|---|---|
| State | Accepted |
| Commit | c57cae78bfa6a8535d4baade451107b0577c2750 |
| Headers | show |
| Series | CXL Region Creation / HDM decoder programming | expand |
s/cxl: Add helper for new drivers/cxl: Introduce module_cxl_driver/ ...as "Add helper for new drivers" could be any kind of helper anywhere in the stack. On Fri, Oct 22, 2021 at 11:37 AM Ben Widawsky <ben.widawsky@intel.com> wrote: > > Many CXL drivers simply want to register and unregister themselves. > module_driver already supported this. A simple wrapper around that > reduces a decent amount of boilerplate in upcoming patches. > Other than the subject clarification, looks good to me. > Suggested-by: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> > --- > drivers/cxl/cxl.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index f06c596fad71..4483e1a39fc3 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -317,6 +317,9 @@ int __cxl_driver_register(struct cxl_driver *cxl_drv, struct module *owner, > #define cxl_driver_register(x) __cxl_driver_register(x, THIS_MODULE, KBUILD_MODNAME) > void cxl_driver_unregister(struct cxl_driver *cxl_drv); > > +#define module_cxl_driver(__cxl_driver) \ > + module_driver(__cxl_driver, cxl_driver_register, cxl_driver_unregister) > + > #define CXL_DEVICE_NVDIMM_BRIDGE 1 > #define CXL_DEVICE_NVDIMM 2 > > -- > 2.33.1 >
diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h index f06c596fad71..4483e1a39fc3 100644 --- a/drivers/cxl/cxl.h +++ b/drivers/cxl/cxl.h @@ -317,6 +317,9 @@ int __cxl_driver_register(struct cxl_driver *cxl_drv, struct module *owner, #define cxl_driver_register(x) __cxl_driver_register(x, THIS_MODULE, KBUILD_MODNAME) void cxl_driver_unregister(struct cxl_driver *cxl_drv); +#define module_cxl_driver(__cxl_driver) \ + module_driver(__cxl_driver, cxl_driver_register, cxl_driver_unregister) + #define CXL_DEVICE_NVDIMM_BRIDGE 1 #define CXL_DEVICE_NVDIMM 2
Many CXL drivers simply want to register and unregister themselves. module_driver already supported this. A simple wrapper around that reduces a decent amount of boilerplate in upcoming patches. Suggested-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> --- drivers/cxl/cxl.h | 3 +++ 1 file changed, 3 insertions(+)