| Message ID | 20211110191425.3761515-1-ira.weiny@intel.com |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cxl/memdev: Clean up the function declaration of cxl_add_memdev() | expand |
On Wed, Nov 10, 2021 at 11:14 AM <ira.weiny@intel.com> wrote: > > From: Ira Weiny <ira.weiny@intel.com> > > Function return type and declaration should be on the same line. > > [1] https://lore.kernel.org/linux-cxl/20211103223413.n6fmf3gtop56wssz@intel.com/T/#m75fee4f12193169da20278cd48e9c655e904c88e > > Suggested-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com> > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > --- > drivers/cxl/core/memdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 5341b0ba99a7..61029cb7ac62 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -276,8 +276,7 @@ static const struct file_operations cxl_memdev_fops = { > .llseek = noop_llseek, > }; > > -struct cxl_memdev * > -devm_cxl_add_memdev(struct cxl_dev_state *cxlds) > +struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) I went ahead and just folded this in since this commit has not been finalized on cxl/next yet.
On Wed, Nov 10, 2021 at 02:26:01PM -0800, Dan Williams wrote: > On Wed, Nov 10, 2021 at 11:14 AM <ira.weiny@intel.com> wrote: > > > > From: Ira Weiny <ira.weiny@intel.com> > > > > Function return type and declaration should be on the same line. > > > > [1] https://lore.kernel.org/linux-cxl/20211103223413.n6fmf3gtop56wssz@intel.com/T/#m75fee4f12193169da20278cd48e9c655e904c88e > > > > Suggested-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > --- > > drivers/cxl/core/memdev.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > > index 5341b0ba99a7..61029cb7ac62 100644 > > --- a/drivers/cxl/core/memdev.c > > +++ b/drivers/cxl/core/memdev.c > > @@ -276,8 +276,7 @@ static const struct file_operations cxl_memdev_fops = { > > .llseek = noop_llseek, > > }; > > > > -struct cxl_memdev * > > -devm_cxl_add_memdev(struct cxl_dev_state *cxlds) > > +struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) > > I went ahead and just folded this in since this commit has not been > finalized on cxl/next yet. Works for me! Thanks. Ira
diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c index 5341b0ba99a7..61029cb7ac62 100644 --- a/drivers/cxl/core/memdev.c +++ b/drivers/cxl/core/memdev.c @@ -276,8 +276,7 @@ static const struct file_operations cxl_memdev_fops = { .llseek = noop_llseek, }; -struct cxl_memdev * -devm_cxl_add_memdev(struct cxl_dev_state *cxlds) +struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) { struct cxl_memdev *cxlmd; struct device *dev;