| Message ID | 20220407010915.1211258-1-alison.schofield@intel.com |
|---|---|
| State | Accepted |
| Commit | 280302f0e8f6919f0c591753ea21906d77797746 |
| Headers | show |
| Series | cxl/mbox: Replace NULL check with IS_ERR() after vmemdup_user() | expand |
On Wed, Apr 06, 2022 at 06:09:15PM -0700, Alison Schofield wrote: > From: Alison Schofield <alison.schofield@intel.com> > > vmemdup_user() returns an ERR_PTR() on failure. Use IS_ERR() > to check the return value. > > Fixes: be0d0ce77aa3 ("cxl/mbox: Move build of user mailbox cmd to a helper funct > ions") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Alison Schofield <alison.schofield@intel.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> > --- > drivers/cxl/core/mbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 8a8388599a85..2449878d4b4b 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -263,7 +263,7 @@ static int cxl_mbox_cmd_ctor(struct cxl_mbox_cmd *mbox, > if (in_size) { > mbox->payload_in = vmemdup_user(u64_to_user_ptr(in_payload), > in_size); > - if (!mbox->payload_in) > + if (IS_ERR(mbox->payload_in)) > return PTR_ERR(mbox->payload_in); > > if (!cxl_payload_from_user_allowed(opcode, mbox->payload_in)) { > > base-commit: 7dc1d11d7abae52aada5340fb98885f0ddbb7c37 > -- > 2.31.1 >
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 8a8388599a85..2449878d4b4b 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -263,7 +263,7 @@ static int cxl_mbox_cmd_ctor(struct cxl_mbox_cmd *mbox, if (in_size) { mbox->payload_in = vmemdup_user(u64_to_user_ptr(in_payload), in_size); - if (!mbox->payload_in) + if (IS_ERR(mbox->payload_in)) return PTR_ERR(mbox->payload_in); if (!cxl_payload_from_user_allowed(opcode, mbox->payload_in)) {