| Message ID | 20221206-vv-misc-v1-2-4c5bd58c90ca@intel.com |
|---|---|
| State | Accepted |
| Commit | 95faaa09cf1c455a1b5d2fb934a0b96367d0f189 |
| Headers | show |
| Series | misc meson.build and clang-format updates | expand |
Vishal Verma wrote: > Meson has started to warn about: > > WARNING: You should add the boolean check kwarg to the run_command call. > It currently defaults to false, > but it will default to true in future releases of meson. > See also: https://github.com/mesonbuild/meson/issues/9300 > > There is one instance of run_command() in the top-level meson.build > which elides the explicit check argument. Since we don't care about the > result of clean_config.sh (if any config.h are found they will be > cleaned, and if none are found, we're fine), add a 'check: false' > argument to this and squelch the warning. Looks good to me: Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/meson.build b/meson.build index 20a646d..33ed0ed 100644 --- a/meson.build +++ b/meson.build @@ -89,6 +89,7 @@ env = find_program('env') if git.found() run_command('clean_config.sh', env : 'GIT_DIR=@0@/.git'.format(project_source_root), + check : false, ) endif
Meson has started to warn about: WARNING: You should add the boolean check kwarg to the run_command call. It currently defaults to false, but it will default to true in future releases of meson. See also: https://github.com/mesonbuild/meson/issues/9300 There is one instance of run_command() in the top-level meson.build which elides the explicit check argument. Since we don't care about the result of clean_config.sh (if any config.h are found they will be cleaned, and if none are found, we're fine), add a 'check: false' argument to this and squelch the warning. Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- meson.build | 1 + 1 file changed, 1 insertion(+)