| Message ID | 20221219195050.325959-1-mcgrof@kernel.org |
|---|---|
| State | Accepted |
| Commit | f45d63c1218636f77b9c3c53318c56ecd27dc8ec |
| Headers | show |
| Series | cxl_test: require 64-bit | expand |
Luis Chamberlain wrote: > size_t is limited to 32-bits and so the gen_pool_alloc() using > the size of SZ_64G would map to 0, triggering a low allocation > which is not expected. Force the dependency on 64-bit for cxl_test > as that is what it was designed for. > > This issue was found by build test reports when converting this > driver as a proper upstream driver. Looks good to me, changed the subject to tools/testing/cxl/ and applied for 6.3.
diff --git a/tools/testing/cxl/config_check.c b/tools/testing/cxl/config_check.c index c4c457e59841..99b56b5f6edf 100644 --- a/tools/testing/cxl/config_check.c +++ b/tools/testing/cxl/config_check.c @@ -7,6 +7,7 @@ void check(void) * These kconfig symbols must be set to "m" for cxl_test to load * and operate. */ + BUILD_BUG_ON(!IS_ENABLED(CONFIG_64BIT)); BUILD_BUG_ON(!IS_MODULE(CONFIG_CXL_BUS)); BUILD_BUG_ON(!IS_MODULE(CONFIG_CXL_ACPI)); BUILD_BUG_ON(!IS_MODULE(CONFIG_CXL_PMEM));
size_t is limited to 32-bits and so the gen_pool_alloc() using the size of SZ_64G would map to 0, triggering a low allocation which is not expected. Force the dependency on 64-bit for cxl_test as that is what it was designed for. This issue was found by build test reports when converting this driver as a proper upstream driver. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- tools/testing/cxl/config_check.c | 1 + 1 file changed, 1 insertion(+)