diff mbox series

[5/5] cxl/type3: Remove superfluous statements

Message ID 20230418172337.19207-6-dave@stgolabs.net
State New, archived
Headers show
Series cxl: Background commands and device Sanitation | expand

Commit Message

Davidlohr Bueso April 18, 2023, 5:23 p.m. UTC 
Simple cleanup while going through the code, remove the
bogus return statements from end of void returning
functions.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
 hw/mem/cxl_type3.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Jonathan Cameron May 15, 2023, 12:53 p.m. UTC | #1 
On Tue, 18 Apr 2023 10:23:37 -0700
Davidlohr Bueso <dave@stgolabs.net> wrote:

> Simple cleanup while going through the code, remove the
> bogus return statements from end of void returning
> functions.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>

LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

I'll pick up this version if its the appropriate one when
I next update my qemu tree.  Might make minimal tweaks as per
feedback if I remember to do so. I'll let you know if I do
anything more significant.

Thanks,

Jonathan

> ---
>  hw/mem/cxl_type3.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
> index 707bdc263f03..415a8c8a3973 100644
> --- a/hw/mem/cxl_type3.c
> +++ b/hw/mem/cxl_type3.c
> @@ -864,7 +864,6 @@ err_address_space_free:
>      if (ct3d->hostvmem) {
>          address_space_destroy(&ct3d->hostvmem_as);
>      }
> -    return;
>  }
>  
>  static void ct3_exit(PCIDevice *pci_dev)
> @@ -1290,8 +1289,6 @@ void qmp_cxl_inject_uncorrectable_errors(const char *path,
>  
>      stl_le_p(reg_state + R_CXL_RAS_UNC_ERR_STATUS, unc_err);
>      pcie_aer_inject_error(PCI_DEVICE(obj), &err);
> -
> -    return;
>  }
>  
>  void qmp_cxl_inject_correctable_error(const char *path, CxlCorErrorType type,
> @@ -1564,7 +1561,6 @@ void qmp_cxl_inject_dram_event(const char *path, CxlEventLog log, uint8_t flags,
>      if (cxl_event_insert(cxlds, enc_log, (CXLEventRecordRaw *)&dram)) {
>          cxl_event_irq_assert(ct3d);
>      }
> -    return;
>  }
>  
>  void qmp_cxl_inject_memory_module_event(const char *path, CxlEventLog log,
diff mbox series

Patch

diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index 707bdc263f03..415a8c8a3973 100644
--- a/hw/mem/cxl_type3.c
+++ b/hw/mem/cxl_type3.c
@@ -864,7 +864,6 @@  err_address_space_free:
     if (ct3d->hostvmem) {
         address_space_destroy(&ct3d->hostvmem_as);
     }
-    return;
 }
 
 static void ct3_exit(PCIDevice *pci_dev)
@@ -1290,8 +1289,6 @@  void qmp_cxl_inject_uncorrectable_errors(const char *path,
 
     stl_le_p(reg_state + R_CXL_RAS_UNC_ERR_STATUS, unc_err);
     pcie_aer_inject_error(PCI_DEVICE(obj), &err);
-
-    return;
 }
 
 void qmp_cxl_inject_correctable_error(const char *path, CxlCorErrorType type,
@@ -1564,7 +1561,6 @@  void qmp_cxl_inject_dram_event(const char *path, CxlEventLog log, uint8_t flags,
     if (cxl_event_insert(cxlds, enc_log, (CXLEventRecordRaw *)&dram)) {
         cxl_event_irq_assert(ct3d);
     }
-    return;
 }
 
 void qmp_cxl_inject_memory_module_event(const char *path, CxlEventLog log,