| Message ID | 20230921025110.3717583-7-jtp.park@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cxl: Fix checkpatch issues | expand |
On 9/20/23 19:51, Jeongtae Park wrote: > ERROR: code indent should use tabs where possible > WARNING: please, no spaces at the start of a line > > Signed-off-by: Jeongtae Park <jtp.park@samsung.com> two different issues? > --- > drivers/cxl/core/memdev.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index f99e7ec3cc40..ce67df163452 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl) > } > > static const struct fw_upload_ops cxl_memdev_fw_ops = { > - .prepare = cxl_fw_prepare, > - .write = cxl_fw_write, > - .poll_complete = cxl_fw_poll_complete, > - .cancel = cxl_fw_cancel, > - .cleanup = cxl_fw_cleanup, > + .prepare = cxl_fw_prepare, > + .write = cxl_fw_write, > + .poll_complete = cxl_fw_poll_complete, > + .cancel = cxl_fw_cancel, > + .cleanup = cxl_fw_cleanup, > }; > > static void devm_cxl_remove_fw_upload(void *fwl) > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) > } > > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); > - } > +} > > struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) > {
On Thu, Sep 21, 2023 at 03:57:25PM -0700, Dave Jiang wrote: > > > On 9/20/23 19:51, Jeongtae Park wrote: > > ERROR: code indent should use tabs where possible > > WARNING: please, no spaces at the start of a line > > > > Signed-off-by: Jeongtae Park <jtp.park@samsung.com> > > two different issues? > Yes, they are. I will seperate and resend them. > > --- > > drivers/cxl/core/memdev.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > > index f99e7ec3cc40..ce67df163452 100644 > > --- a/drivers/cxl/core/memdev.c > > +++ b/drivers/cxl/core/memdev.c > > @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl) > > } > > > > static const struct fw_upload_ops cxl_memdev_fw_ops = { > > - .prepare = cxl_fw_prepare, > > - .write = cxl_fw_write, > > - .poll_complete = cxl_fw_poll_complete, > > - .cancel = cxl_fw_cancel, > > - .cleanup = cxl_fw_cleanup, > > + .prepare = cxl_fw_prepare, > > + .write = cxl_fw_write, > > + .poll_complete = cxl_fw_poll_complete, > > + .cancel = cxl_fw_cancel, > > + .cleanup = cxl_fw_cleanup, > > }; > > > > static void devm_cxl_remove_fw_upload(void *fwl) > > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) > > } > > > > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); > > - } > > +} > > > > struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) > > {
diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c index f99e7ec3cc40..ce67df163452 100644 --- a/drivers/cxl/core/memdev.c +++ b/drivers/cxl/core/memdev.c @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl) } static const struct fw_upload_ops cxl_memdev_fw_ops = { - .prepare = cxl_fw_prepare, - .write = cxl_fw_write, - .poll_complete = cxl_fw_poll_complete, - .cancel = cxl_fw_cancel, - .cleanup = cxl_fw_cleanup, + .prepare = cxl_fw_prepare, + .write = cxl_fw_write, + .poll_complete = cxl_fw_poll_complete, + .cancel = cxl_fw_cancel, + .cleanup = cxl_fw_cleanup, }; static void devm_cxl_remove_fw_upload(void *fwl) @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) } return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); - } +} struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) {
ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Jeongtae Park <jtp.park@samsung.com> --- drivers/cxl/core/memdev.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)