diff mbox series

[v2,6/7] cxl/memdev: Fix a whitespace error

Message ID 20230922113636.3301482-1-jtp.park@samsung.com
State Superseded
Headers show
Series cxl: Fix checkpatch issues | expand

Commit Message

Jeongtae Park Sept. 22, 2023, 11:36 a.m. UTC
ERROR: code indent should use tabs where possible

Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
---
 drivers/cxl/core/memdev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Dave Jiang Sept. 22, 2023, 3:07 p.m. UTC | #1
On 9/22/23 04:36, Jeongtae Park wrote:
> ERROR: code indent should use tabs where possible
> 
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/memdev.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index f99e7ec3cc40..7e8fca4707c0 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
>  }
>  
>  static const struct fw_upload_ops cxl_memdev_fw_ops = {
> -        .prepare = cxl_fw_prepare,
> -        .write = cxl_fw_write,
> -        .poll_complete = cxl_fw_poll_complete,
> -        .cancel = cxl_fw_cancel,
> -        .cleanup = cxl_fw_cleanup,
> +	.prepare = cxl_fw_prepare,
> +	.write = cxl_fw_write,
> +	.poll_complete = cxl_fw_poll_complete,
> +	.cancel = cxl_fw_cancel,
> +	.cleanup = cxl_fw_cleanup,
>  };
>  
>  static void devm_cxl_remove_fw_upload(void *fwl)
Jonathan Cameron Sept. 25, 2023, 10:12 a.m. UTC | #2
On Fri, 22 Sep 2023 20:36:36 +0900
Jeongtae Park <jtp.park@samsung.com> wrote:

> ERROR: code indent should use tabs where possible
> 
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

These whitespace ones are simple enough RB feels over the top :)

Jonathan

> ---
>  drivers/cxl/core/memdev.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index f99e7ec3cc40..7e8fca4707c0 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
>  }
>  
>  static const struct fw_upload_ops cxl_memdev_fw_ops = {
> -        .prepare = cxl_fw_prepare,
> -        .write = cxl_fw_write,
> -        .poll_complete = cxl_fw_poll_complete,
> -        .cancel = cxl_fw_cancel,
> -        .cleanup = cxl_fw_cleanup,
> +	.prepare = cxl_fw_prepare,
> +	.write = cxl_fw_write,
> +	.poll_complete = cxl_fw_poll_complete,
> +	.cancel = cxl_fw_cancel,
> +	.cleanup = cxl_fw_cleanup,
>  };
>  
>  static void devm_cxl_remove_fw_upload(void *fwl)
diff mbox series

Patch

diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
index f99e7ec3cc40..7e8fca4707c0 100644
--- a/drivers/cxl/core/memdev.c
+++ b/drivers/cxl/core/memdev.c
@@ -935,11 +935,11 @@  static void cxl_fw_cancel(struct fw_upload *fwl)
 }
 
 static const struct fw_upload_ops cxl_memdev_fw_ops = {
-        .prepare = cxl_fw_prepare,
-        .write = cxl_fw_write,
-        .poll_complete = cxl_fw_poll_complete,
-        .cancel = cxl_fw_cancel,
-        .cleanup = cxl_fw_cleanup,
+	.prepare = cxl_fw_prepare,
+	.write = cxl_fw_write,
+	.poll_complete = cxl_fw_poll_complete,
+	.cancel = cxl_fw_cancel,
+	.cleanup = cxl_fw_cleanup,
 };
 
 static void devm_cxl_remove_fw_upload(void *fwl)