| Message ID | 20230922113650.3301992-1-jtp.park@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cxl: Fix checkpatch issues | expand |
On 9/22/23 04:36, Jeongtae Park wrote: > WARNING: please, no spaces at the start of a line > > Signed-off-by: Jeongtae Park <jtp.park@samsung.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/cxl/core/memdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 7e8fca4707c0..ce67df163452 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) > } > > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); > - } > +} > > struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) > {
On Fri, 22 Sep 2023 20:36:50 +0900 Jeongtae Park <jtp.park@samsung.com> wrote: > WARNING: please, no spaces at the start of a line > > Signed-off-by: Jeongtae Park <jtp.park@samsung.com> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/core/memdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 7e8fca4707c0..ce67df163452 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) > } > > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); > - } > +} > > struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) > {
On Fri, 22 Sep 2023, Jeongtae Park wrote: >WARNING: please, no spaces at the start of a line > >Signed-off-by: Jeongtae Park <jtp.park@samsung.com> >--- > drivers/cxl/core/memdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c >index 7e8fca4707c0..ce67df163452 100644 >--- a/drivers/cxl/core/memdev.c >+++ b/drivers/cxl/core/memdev.c >@@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) > } > > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); >- } >+} While nothing wrong, I do prefer this being corrected via https://lore.kernel.org/linux-cxl/20230811025755.15103-1-dave@stgolabs.net/ Thanks, Davidlohr
On Wed, Sep 27, 2023 at 06:31:37PM -0700, Davidlohr Bueso wrote: > On Fri, 22 Sep 2023, Jeongtae Park wrote: > > > WARNING: please, no spaces at the start of a line > > > > Signed-off-by: Jeongtae Park <jtp.park@samsung.com> > > --- > > drivers/cxl/core/memdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > > index 7e8fca4707c0..ce67df163452 100644 > > --- a/drivers/cxl/core/memdev.c > > +++ b/drivers/cxl/core/memdev.c > > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) > > } > > > > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); > > - } > > +} > > While nothing wrong, I do prefer this being corrected via > > https://lore.kernel.org/linux-cxl/20230811025755.15103-1-dave@stgolabs.net/ That's better, I didn't know there was a related fix. Thanks for letting me know. > > Thanks, > Davidlohr
diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c index 7e8fca4707c0..ce67df163452 100644 --- a/drivers/cxl/core/memdev.c +++ b/drivers/cxl/core/memdev.c @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd) } return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds); - } +} struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds) {
WARNING: please, no spaces at the start of a line Signed-off-by: Jeongtae Park <jtp.park@samsung.com> --- drivers/cxl/core/memdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)