diff mbox series

[ndctl,RESEND] test/cxl-event: Skip cxl event testing if cxl-test is not available

Message ID 20230925-skip-cxl-events-v1-1-bdad7cceb80b@intel.com
State Accepted
Commit d32dc015ad5b18fc37d3d7f10dd1f0a5442d3b7c
Headers show
Series [ndctl,RESEND] test/cxl-event: Skip cxl event testing if cxl-test is not available | expand

Commit Message

Ira Weiny Sept. 25, 2023, 10:16 p.m. UTC
CXL event testing is only appropriate when the cxl-test modules are
available.

Return error 77 (skip) if cxl-test modules are not available.

Reported-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
Changes for resend:
- iweiny: properly cc the mailing lists
---
 test/cxl-events.sh | 3 +++
 1 file changed, 3 insertions(+)


---
base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c
change-id: 20230925-skip-cxl-events-7f16052b9c4e

Best regards,

Comments

Dave Jiang Sept. 25, 2023, 10:37 p.m. UTC | #1
On 9/25/23 15:16, Ira Weiny wrote:
> CXL event testing is only appropriate when the cxl-test modules are
> available.
> 
> Return error 77 (skip) if cxl-test modules are not available.
> 
> Reported-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> Changes for resend:
> - iweiny: properly cc the mailing lists
> ---
>  test/cxl-events.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/test/cxl-events.sh b/test/cxl-events.sh
> index 33b68daa6ade..fe702bf98ad4 100644
> --- a/test/cxl-events.sh
> +++ b/test/cxl-events.sh
> @@ -10,6 +10,8 @@ num_fatal_expected=2
>  num_failure_expected=16
>  num_info_expected=3
>  
> +rc=77
> +
>  set -ex
>  
>  trap 'err $LINENO' ERR
> @@ -18,6 +20,7 @@ check_prereq "jq"
>  
>  modprobe -r cxl_test
>  modprobe cxl_test
> +rc=1
>  
>  dev_path="/sys/bus/platform/devices"
>  
> 
> ---
> base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c
> change-id: 20230925-skip-cxl-events-7f16052b9c4e
> 
> Best regards,
diff mbox series

Patch

diff --git a/test/cxl-events.sh b/test/cxl-events.sh
index 33b68daa6ade..fe702bf98ad4 100644
--- a/test/cxl-events.sh
+++ b/test/cxl-events.sh
@@ -10,6 +10,8 @@  num_fatal_expected=2
 num_failure_expected=16
 num_info_expected=3
 
+rc=77
+
 set -ex
 
 trap 'err $LINENO' ERR
@@ -18,6 +20,7 @@  check_prereq "jq"
 
 modprobe -r cxl_test
 modprobe cxl_test
+rc=1
 
 dev_path="/sys/bus/platform/devices"