diff mbox series

[v2] tools/testing/cxl: slow down the mock firmware transfer

Message ID 20231026-vv-fw_upd_test_fix-v2-1-5282fd193883@intel.com
State Accepted
Commit f2f39c016c0e8ee10f5c38f47f9101dc50796d71
Headers show
Series [v2] tools/testing/cxl: slow down the mock firmware transfer | expand

Commit Message

Verma, Vishal L Oct. 26, 2023, 5:32 p.m. UTC 
The cxl-cli unit test for firmware update does operations like starting
an asynchronous firmware update, making sure it is in progress, and
attempting to cancel it. In some cases, such as with no or minimal
dynamic debugging turned on, the firmware update completes too quickly,
not allowing the test to have a chance to verify it was in progress.
This caused a failure of the signature:

  expected fw_update_in_progress:true
  test/cxl-update-firmware.sh: failed at line 88

Fix this by adding a delay (~1.5 - 2 ms) to each firmware transfer
request handled by the mocked interface.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
Changes in v2:
- Checkpatch suggests using usleep_range() instead of udelay()
- Link to v1: https://lore.kernel.org/r/20231026-vv-fw_upd_test_fix-v1-1-a6345df5550b@intel.com
---
 tools/testing/cxl/test/mem.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa
change-id: 20231026-vv-fw_upd_test_fix-533e9a63f005

Best regards,
diff mbox series

Patch

diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
index 464fc39ed277..1195369a4e96 100644
--- a/tools/testing/cxl/test/mem.c
+++ b/tools/testing/cxl/test/mem.c
@@ -1237,6 +1237,7 @@  static int mock_transfer_fw(struct cxl_mockmem_data *mdata,
 	}
 
 	memcpy(fw + offset, transfer->data, length);
+	usleep_range(1500, 2000);
 	return 0;
 }