| Message ID | 20240208200042.432958-2-Benjamin.Cheatham@amd.com |
|---|---|
| State | New, archived |
| Headers | show |
| Series | CXL, ACPI, APEI, EINJ: Update EINJ for CXL error types | expand |
On Thu, 8 Feb 2024 14:00:39 -0600 Ben Cheatham <Benjamin.Cheatham@amd.com> wrote: > Add CONFIG_CXL_EINJ to cxl/Kconfig. This option will allow for the CXL > core module to access helpers inside the EINJ module, while also giving > users the option of disabling CXL EINJ error types at build time. > > Also update CONFIG_ACPI_APEI_EINJ to set CONFIG_CXL_EINJ by default. > > Reviewed-by: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Ben Cheatham <Benjamin.Cheatham@amd.com> Hi Ben, I'm not a particular fan of Kconfig only patches, so would personally have squashed this with patch 3 (or wherever it gets used) That would also have had the side effect of making it clear this doesn't actually get used (you and Dan have been discussing how it should be). Jonathan > --- > drivers/cxl/Kconfig | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig > index 67998dbd1d46..95f215a2e5dc 100644 > --- a/drivers/cxl/Kconfig > +++ b/drivers/cxl/Kconfig > @@ -157,4 +157,16 @@ config CXL_PMU > monitoring units and provide standard perf based interfaces. > > If unsure say 'm'. > + > +config CXL_EINJ > + bool "CXL Error INJection Support" > + default ACPI_APEI_EINJ > + depends on ACPI_APEI_EINJ >= CXL_BUS > + help > + Support for CXL protocol Error INJection through debugfs/cxl. > + Availability and which errors are supported is dependent on > + the host platform. Look to ACPI v6.5 section 18.6.4 and kernel > + EINJ documentation for more information. > + > + If unsure say 'n' > endif
On 2/14/24 8:05 AM, Jonathan Cameron wrote: > On Thu, 8 Feb 2024 14:00:39 -0600 > Ben Cheatham <Benjamin.Cheatham@amd.com> wrote: > >> Add CONFIG_CXL_EINJ to cxl/Kconfig. This option will allow for the CXL >> core module to access helpers inside the EINJ module, while also giving >> users the option of disabling CXL EINJ error types at build time. >> >> Also update CONFIG_ACPI_APEI_EINJ to set CONFIG_CXL_EINJ by default. >> >> Reviewed-by: Dan Williams <dan.j.williams@intel.com> >> Signed-off-by: Ben Cheatham <Benjamin.Cheatham@amd.com> > > Hi Ben, > > I'm not a particular fan of Kconfig only patches, so would personally > have squashed this with patch 3 (or wherever it gets used) > > That would also have had the side effect of making it clear this > doesn't actually get used (you and Dan have been discussing how > it should be). > > Jonathan > I agree, I'll fold this in to patch 3. Thanks, Ben > >> --- >> drivers/cxl/Kconfig | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig >> index 67998dbd1d46..95f215a2e5dc 100644 >> --- a/drivers/cxl/Kconfig >> +++ b/drivers/cxl/Kconfig >> @@ -157,4 +157,16 @@ config CXL_PMU >> monitoring units and provide standard perf based interfaces. >> >> If unsure say 'm'. >> + >> +config CXL_EINJ >> + bool "CXL Error INJection Support" >> + default ACPI_APEI_EINJ >> + depends on ACPI_APEI_EINJ >= CXL_BUS >> + help >> + Support for CXL protocol Error INJection through debugfs/cxl. >> + Availability and which errors are supported is dependent on >> + the host platform. Look to ACPI v6.5 section 18.6.4 and kernel >> + EINJ documentation for more information. >> + >> + If unsure say 'n' >> endif >
diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig index 67998dbd1d46..95f215a2e5dc 100644 --- a/drivers/cxl/Kconfig +++ b/drivers/cxl/Kconfig @@ -157,4 +157,16 @@ config CXL_PMU monitoring units and provide standard perf based interfaces. If unsure say 'm'. + +config CXL_EINJ + bool "CXL Error INJection Support" + default ACPI_APEI_EINJ + depends on ACPI_APEI_EINJ >= CXL_BUS + help + Support for CXL protocol Error INJection through debugfs/cxl. + Availability and which errors are supported is dependent on + the host platform. Look to ACPI v6.5 section 18.6.4 and kernel + EINJ documentation for more information. + + If unsure say 'n' endif