| Message ID | 20240228-cxl-cper3-v1-1-6aa3f1343c6c@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | efi/cxl-cper: Report CXL CPER events through tracing | expand |
Ira Weiny wrote: > Additional event testing using the cxl-event.h header revealed that it > did not include the correct headers for the types used. Compile errors > such as: > > include/linux/cxl-event.h|11 col 9| error: unknown type name ‘u8’ > > ... were seen. Were seen where? Should this have the trio of Reported-by: Closes: and Fixes tags?
Dan Williams wrote: > Ira Weiny wrote: > > Additional event testing using the cxl-event.h header revealed that it > > did not include the correct headers for the types used. Compile errors > > such as: > > > > include/linux/cxl-event.h|11 col 9| error: unknown type name ‘u8’ > > > > ... were seen. > > Were seen where? Should this have the trio of Reported-by: Closes: and > Fixes tags? As I said after this in the commit message: "Omit the fixes tag because this does not cause any issues until the header is used again in other code." I'll clarify it was seen when I used cxl-event.h in the testing code and this happened. Ira
diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h index 03fa6d50d46f..812ed16ffc2f 100644 --- a/include/linux/cxl-event.h +++ b/include/linux/cxl-event.h @@ -3,6 +3,9 @@ #ifndef _LINUX_CXL_EVENT_H #define _LINUX_CXL_EVENT_H +#include <linux/types.h> +#include <linux/uuid.h> + /* * Common Event Record Format * CXL rev 3.0 section 8.2.9.2.1; Table 8-42
Additional event testing using the cxl-event.h header revealed that it did not include the correct headers for the types used. Compile errors such as: include/linux/cxl-event.h|11 col 9| error: unknown type name ‘u8’ ... were seen. Add the correct pre-requisite headers. Omit the fixes tag because this does not cause any issues until the header is used again in other code. Signed-off-by: Ira Weiny <ira.weiny@intel.com> --- include/linux/cxl-event.h | 3 +++ 1 file changed, 3 insertions(+)