| Message ID | 20240417035043.2791431-1-sangyun.kim@snu.ac.kr |
|---|---|
| State | Accepted |
| Commit | 2f32e0bd206c5e8a8ea61c9b0cef2bd403931f86 |
| Headers | show |
| Series | cxl/cxl-event: include missing <linux/types.h> and <linux/uuid.h> | expand |
Sangyun Kim wrote: > The linux/cxl-event.h header file uses the u8, u16, and uuid_t types, > but it doesn't include the necessary header files, > <linux/types.h> and <linux/uuid.h>. > > Currently, cxl-event.h is only used by drivers/cxl/cxlmem.h, > and it doesn't cause any errors because cxlmem.h indirectly > includes the required types. > > However, cxl-event.h may be used by other CXL-related code in the future, > so it's important to fix this issue by including the missing header files > directly in cxl-event.h. > > Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr> I pointed this out before. https://lore.kernel.org/all/20240228-cxl-cper3-v1-1-6aa3f1343c6c@intel.com/ Dan suggested a fixes tag. I did not think it was technically required but it would be nice. Regardless. Reviewed-by: Ira Weiny <ira.weiny@intel.com> > --- > include/linux/cxl-event.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h > index 03fa6d50d46f..812ed16ffc2f 100644 > --- a/include/linux/cxl-event.h > +++ b/include/linux/cxl-event.h > @@ -3,6 +3,9 @@ > #ifndef _LINUX_CXL_EVENT_H > #define _LINUX_CXL_EVENT_H > > +#include <linux/types.h> > +#include <linux/uuid.h> > + > /* > * Common Event Record Format > * CXL rev 3.0 section 8.2.9.2.1; Table 8-42 > -- > 2.25.1 >
diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h index 03fa6d50d46f..812ed16ffc2f 100644 --- a/include/linux/cxl-event.h +++ b/include/linux/cxl-event.h @@ -3,6 +3,9 @@ #ifndef _LINUX_CXL_EVENT_H #define _LINUX_CXL_EVENT_H +#include <linux/types.h> +#include <linux/uuid.h> + /* * Common Event Record Format * CXL rev 3.0 section 8.2.9.2.1; Table 8-42
The linux/cxl-event.h header file uses the u8, u16, and uuid_t types, but it doesn't include the necessary header files, <linux/types.h> and <linux/uuid.h>. Currently, cxl-event.h is only used by drivers/cxl/cxlmem.h, and it doesn't cause any errors because cxlmem.h indirectly includes the required types. However, cxl-event.h may be used by other CXL-related code in the future, so it's important to fix this issue by including the missing header files directly in cxl-event.h. Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr> --- include/linux/cxl-event.h | 3 +++ 1 file changed, 3 insertions(+)