| Message ID | 20240520193106.994172-1-nifan.cxl@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | cxl/region: Add module license declaration to cxl region module source code | expand |
nifan.cxl@ wrote: > From: Fan Ni <fan.ni@samsung.com> > > This change explicitly specifies the licensing terms for the CXL region > module as GPL v2. This commit does not introduce any functional changes > to the behavior or functionality of the CXL region module. > It solely adds the MODULE_LICENSE declaration to the module source file. Why is this needed? The region code is added to cxl_core when built and that module already reports the correct module license. 10:24:55 > modinfo cxl_core | grep lic license: GPL v2 Ira > > Signed-off-by: Fan Ni <fan.ni@samsung.com> > --- > drivers/cxl/core/region.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index 5c186e0a39b9..e299ddcbd1a2 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -3204,3 +3204,4 @@ void cxl_region_exit(void) > MODULE_IMPORT_NS(CXL); > MODULE_IMPORT_NS(DEVMEM); > MODULE_ALIAS_CXL(CXL_DEVICE_REGION); > +MODULE_LICENSE("GPL v2"); > -- > 2.43.0 >
Ira Weiny wrote: > nifan.cxl@ wrote: > > From: Fan Ni <fan.ni@samsung.com> > > > > This change explicitly specifies the licensing terms for the CXL region > > module as GPL v2. This commit does not introduce any functional changes > > to the behavior or functionality of the CXL region module. > > It solely adds the MODULE_LICENSE declaration to the module source file. > > Why is this needed? The region code is added to cxl_core when built and > that module already reports the correct module license. Right, and region.c has: // SPDX-License-Identifier: GPL-2.0-only
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index 5c186e0a39b9..e299ddcbd1a2 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -3204,3 +3204,4 @@ void cxl_region_exit(void) MODULE_IMPORT_NS(CXL); MODULE_IMPORT_NS(DEVMEM); MODULE_ALIAS_CXL(CXL_DEVICE_REGION); +MODULE_LICENSE("GPL v2");