diff mbox series

[v3,08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()

Message ID 20241205-const_dfc_done-v3-8-1611f1486b5a@quicinc.com
State Superseded
Headers show
Series driver core: Constify API device_find_child() | expand

Commit Message

Zijun Hu Dec. 5, 2024, 12:10 a.m. UTC 
From: Zijun Hu <quic_zijuhu@quicinc.com>

gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
Remvoe the unnecessary wrapper.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 drivers/gpio/gpio-sim.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Uwe Kleine-König Dec. 5, 2024, 8:10 a.m. UTC | #1 
On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
> Remvoe the unnecessary wrapper.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  drivers/gpio/gpio-sim.c | 7 +------

I think if you move this patch before patch #4 in your series, you only
have to touch this file once.

Best regards
Uwe
quic_zijuhu Dec. 5, 2024, 8:37 a.m. UTC | #2 
On 12/5/2024 4:10 PM, Uwe Kleine-König wrote:
> On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
>> Remvoe the unnecessary wrapper.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>>  drivers/gpio/gpio-sim.c | 7 +------
> 
> I think if you move this patch before patch #4 in your series, you only
> have to touch this file once.

the precondition of this change is patch #4, it will have building error
if moving it before #4.

actually, we can only do simplifications with benefits brought by #4.
> 
> Best regards
> Uwe
Uwe Kleine-König Dec. 5, 2024, 10:37 a.m. UTC | #3 
On Thu, Dec 05, 2024 at 04:37:08PM +0800, quic_zijuhu wrote:
> On 12/5/2024 4:10 PM, Uwe Kleine-König wrote:
> > On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote:
> >> From: Zijun Hu <quic_zijuhu@quicinc.com>
> >>
> >> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
> >> Remvoe the unnecessary wrapper.

Just spotted: s/Remvoe/Remove/

> >> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> >> ---
> >>  drivers/gpio/gpio-sim.c | 7 +------
> > 
> > I think if you move this patch before patch #4 in your series, you only
> > have to touch this file once.
> 
> the precondition of this change is patch #4, it will have building error
> if moving it before #4.
> 
> actually, we can only do simplifications with benefits brought by #4.

Ah I see. I thought that device_match_fwnode only got the const for the
2nd parameter in patch #4.

Best regards
Uwe
Zijun Hu Dec. 5, 2024, 1:19 p.m. UTC | #4 
On 2024/12/5 18:37, Uwe Kleine-König wrote:
> On Thu, Dec 05, 2024 at 04:37:08PM +0800, quic_zijuhu wrote:
>> On 12/5/2024 4:10 PM, Uwe Kleine-König wrote:
>>> On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote:
>>>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>>>
>>>> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
>>>> Remvoe the unnecessary wrapper.
> 
> Just spotted: s/Remvoe/Remove/
> 

this typo error is my mistake, will correct it.

>>>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>>>> ---
>>>>  drivers/gpio/gpio-sim.c | 7 +------
>>>
>>> I think if you move this patch before patch #4 in your series, you only
>>> have to touch this file once.
>>
>> the precondition of this change is patch #4, it will have building error
>> if moving it before #4.
>>
>> actually, we can only do simplifications with benefits brought by #4.
> 
> Ah I see. I thought that device_match_fwnode only got the const for the
> 2nd parameter in patch #4.
> 
> Best regards
> Uwe
Bartosz Golaszewski Dec. 5, 2024, 4:24 p.m. UTC | #5 
On Thu, Dec 5, 2024 at 1:15 AM Zijun Hu <zijun_hu@icloud.com> wrote:
>
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
> Remvoe the unnecessary wrapper.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  drivers/gpio/gpio-sim.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -413,11 +413,6 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
>         return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip);
>  }
>
> -static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data)
> -{
> -       return device_match_fwnode(dev, data);
> -}
> -
>  static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
>  {
>         struct gpio_sim_chip *chip;
> @@ -503,7 +498,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
>         if (ret)
>                 return ret;
>
> -       chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode);
> +       chip->dev = device_find_child(dev, swnode, device_match_fwnode);
>         if (!chip->dev)
>                 return -ENODEV;
>
>
> --
> 2.34.1
>
>

Please use get_maintainers.pl to get the complete list of addresses to Cc.

Bartosz
Zijun Hu Dec. 6, 2024, 1 a.m. UTC | #6 
On 2024/12/6 00:24, Bartosz Golaszewski wrote:
> On Thu, Dec 5, 2024 at 1:15 AM Zijun Hu <zijun_hu@icloud.com> wrote:
>>
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
>> Remvoe the unnecessary wrapper.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>>  drivers/gpio/gpio-sim.c | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
>> index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644
>> --- a/drivers/gpio/gpio-sim.c
>> +++ b/drivers/gpio/gpio-sim.c
>> @@ -413,11 +413,6 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
>>         return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip);
>>  }
>>
>> -static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data)
>> -{
>> -       return device_match_fwnode(dev, data);
>> -}
>> -
>>  static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
>>  {
>>         struct gpio_sim_chip *chip;
>> @@ -503,7 +498,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
>>         if (ret)
>>                 return ret;
>>
>> -       chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode);
>> +       chip->dev = device_find_child(dev, swnode, device_match_fwnode);
>>         if (!chip->dev)
>>                 return -ENODEV;
>>
>>
>> --
>> 2.34.1
>>
>>
> 
> Please use get_maintainers.pl to get the complete list of addresses to Cc.

thanks for code review.
will fix it in v4.

> 
> Bartosz
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -413,11 +413,6 @@  static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
 	return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip);
 }
 
-static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data)
-{
-	return device_match_fwnode(dev, data);
-}
-
 static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
 {
 	struct gpio_sim_chip *chip;
@@ -503,7 +498,7 @@  static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
 	if (ret)
 		return ret;
 
-	chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode);
+	chip->dev = device_find_child(dev, swnode, device_match_fwnode);
 	if (!chip->dev)
 		return -ENODEV;