| Message ID | 20250306164448.3354845-15-rrichter@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | cxl: Address translation support, part 1: Cleanups and refactoring | expand |
Robert Richter wrote: > CFMWS entries have a similar importance as SRAT table entries to > describe memory regions. For CXL error analysis and memory debugging > information of both is needed. Unify output of both messages to > improve logging. Change the style of CFMWS message according to SRAT > output. Also, turn messages into a dev_info() same as for SRAT. > > SRAT pr_info() for reference: > > drivers/acpi/numa/srat.c: > pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n", > > Signed-off-by: Robert Richter <rrichter@amd.com> > Reviewed-by: Gregory Price <gourry@gourry.net> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reviewed-by: Dave Jiang <dave.jiang@intel.com> > Tested-by: Gregory Price <gourry@gourry.net> > --- > drivers/cxl/acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) NAK on this one. If you want to add this print the best place would be in acpi_parse_cfmws() so that it can include the PXM information and be independent of the cxl_acpi module loading.
diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c index 3e75e612cbc4..93c73b163c28 100644 --- a/drivers/cxl/acpi.c +++ b/drivers/cxl/acpi.c @@ -447,7 +447,7 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg, cfmws->base_hpa, cfmws->base_hpa + cfmws->window_size - 1, rc); else - dev_dbg(dev, "decode range: node: %d range [%#llx - %#llx]\n", + dev_info(dev, "ACPI: CFMWS: Node %u [mem %#010Lx-%#010Lx]\n", phys_to_target_node(cfmws->base_hpa), cfmws->base_hpa, cfmws->base_hpa + cfmws->window_size - 1);
CFMWS entries have a similar importance as SRAT table entries to describe memory regions. For CXL error analysis and memory debugging information of both is needed. Unify output of both messages to improve logging. Change the style of CFMWS message according to SRAT output. Also, turn messages into a dev_info() same as for SRAT. SRAT pr_info() for reference: drivers/acpi/numa/srat.c: pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n", Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Gregory Price <gourry@gourry.net> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Tested-by: Gregory Price <gourry@gourry.net> --- drivers/cxl/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)