| Message ID | 20250404165418.3032414-1-dave.jiang@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | cxl: Remove always true condition for cxlctl_validate_hw_command() | expand |
On Fri, 4 Apr 2025 09:54:18 -0700 Dave Jiang <dave.jiang@intel.com> wrote: > smatch warnings: > drivers/cxl/core/features.c:441 cxlctl_validate_hw_command() warn: always true condition '(scope >= 0) => (0-u32max >= 0)' > > Remove the check entirely as it has no effect. Expectation is both of these > operations should be allowed for all check levels. They are read only and > have no change effects. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202504041033.2HBboAZR-lkp@intel.com/ > Signed-off-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/core/features.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c > index caf92e9cea21..594f290042e9 100644 > --- a/drivers/cxl/core/features.c > +++ b/drivers/cxl/core/features.c > @@ -614,11 +614,7 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs, > switch (opcode) { > case CXL_MBOX_OP_GET_SUPPORTED_FEATURES: > case CXL_MBOX_OP_GET_FEATURE: > - if (cxl_mbox->feat_cap < CXL_FEATURES_RO) > - return false; > - if (scope >= FWCTL_RPC_CONFIGURATION) > - return true; > - return false; > + return cxl_mbox->feat_cap >= CXL_FEATURES_RO; > case CXL_MBOX_OP_SET_FEATURE: > if (cxl_mbox->feat_cap < CXL_FEATURES_RW) > return false;
Dave Jiang wrote: > smatch warnings: > drivers/cxl/core/features.c:441 cxlctl_validate_hw_command() warn: always true condition '(scope >= 0) => (0-u32max >= 0)' > > Remove the check entirely as it has no effect. Expectation is both of these > operations should be allowed for all check levels. They are read only and > have no change effects. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202504041033.2HBboAZR-lkp@intel.com/ > Signed-off-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> [snip]
diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c index caf92e9cea21..594f290042e9 100644 --- a/drivers/cxl/core/features.c +++ b/drivers/cxl/core/features.c @@ -614,11 +614,7 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs, switch (opcode) { case CXL_MBOX_OP_GET_SUPPORTED_FEATURES: case CXL_MBOX_OP_GET_FEATURE: - if (cxl_mbox->feat_cap < CXL_FEATURES_RO) - return false; - if (scope >= FWCTL_RPC_CONFIGURATION) - return true; - return false; + return cxl_mbox->feat_cap >= CXL_FEATURES_RO; case CXL_MBOX_OP_SET_FEATURE: if (cxl_mbox->feat_cap < CXL_FEATURES_RW) return false;
smatch warnings: drivers/cxl/core/features.c:441 cxlctl_validate_hw_command() warn: always true condition '(scope >= 0) => (0-u32max >= 0)' Remove the check entirely as it has no effect. Expectation is both of these operations should be allowed for all check levels. They are read only and have no change effects. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202504041033.2HBboAZR-lkp@intel.com/ Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- drivers/cxl/core/features.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)