From patchwork Thu Feb 22 06:14:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 13566764 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574E31426A for ; Thu, 22 Feb 2024 06:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708582450; cv=none; b=XdPOLtb74Fq8fh75EteNvBmUgQ1DkCuww6blPN2TXxq5pGdl1LlYnII2xdSAA8jdhpdgDwbebRr6F5zuNjrbPJAzzCLntbjX+fkxwVCXaT0KBIFQ5MfJryEiVGXwC3i87h7R6NdB4z1Av/vrJ2q8lFTh1B2nEOo7aCzmXilRIcg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708582450; c=relaxed/simple; bh=bn5i7/H5MiGU8X0jDHY08Xk8tKztkxjuCmvj7DxUVWU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=rcKLKjWf9ScKAgrkr0cd0xHPLC7G81qcrSkjCAKMrCJ6nFbNh/62LzZHg6wLLtWOPA2kfP0c2i2nyf9pbd5L2rJIIGlZ3zXAT4FjDlWD1AwBDrgSWVeVHIKb4KUTIOw2ZFr9ktLNl4xUqHFw130p34sPvFbeGDbZdh1vhvk4jT4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZssiwUOS; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZssiwUOS" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-512bce554a5so4856259e87.3 for ; Wed, 21 Feb 2024 22:14:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708582446; x=1709187246; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=4SC+H9Oulb2l4KVayVXMGit73eWaz8qeCs2MKjcvOvk=; b=ZssiwUOSH8jikzJYq8ZcP5uGGi6D0dmW7qLMtDVUrOprFj/imhE5lg8l+2JBrT+1Ja jo+dQATSr2viMRGoeXXXZdBuw3hgeLLWfudCiYtdRR9glVeZslvFJqeaxuLyEPGR3Z+6 EVv9XO/cS4V1lTlYl3SP8X8JI9SJONBpwCOBBjYDIzyoRLQMoV8FNTQgzVv7mxLzKHRN 29pK2BNotffTu44O84ADPTQohNQDHcWrpVx6ckGqkg4avFKqTDD4DuLTqXRqoQJqheI4 CBgUglcOQ/9SDcg3YsyB06Xjs91+Nza1AcoG548haDqPcO3ZkYZ794PNYwaxd+cn+cql lZ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708582446; x=1709187246; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4SC+H9Oulb2l4KVayVXMGit73eWaz8qeCs2MKjcvOvk=; b=L2hmCWN8HTv9AqXcwi8iZ5UJabHTTWBwkTY/4xfapnDoRjN1kJF/8ccEMhWGo0xwv9 q3kv2ytJvp7pw/ei1ZETI1X724Y6mIsdhA5m5I1aw9n5NiyYJ0KK6othZsimvkXzpnsT TxWI3cRsYCM9JWAE3jRusTMfJ0tDbrJEVyXI5yT6KOZ7xhaTP3nEbWb01kstZ5/YOqJ2 oi3kUgWaBIydm1RZamdYOdHwMpPQv4wQoAXZhSgnA71mujOgmeeRvXGz01jYCgdhSnqe nl0bu8EEQCnE3pLY6pzZpA3tPgzYFIX5WgWJLd2Tmabzpg+vTV29tTEhn1sodHyU3XkL EZzg== X-Forwarded-Encrypted: i=1; AJvYcCWOz2o4/EqNuHcgTglI88a8gR8wmzpmnw4wh0CJhEZN/0dYkl69fCIxuwH8p5aTgA24FbsUNQlFJ6Gt0WB8nGtVAMwXgw6rh6uA X-Gm-Message-State: AOJu0YxHYCpwi91avJyZKETecIA2s8/gnPou69xjV/W/RLZEqwAlvrKp zgGxjdWh9oqcQjJqOVTy7y/FWlubfugwC44U+QV2f6UOoyS+VQV0Zd9FvfVRXVEnICOw62aqryA Z X-Google-Smtp-Source: AGHT+IEFPpQi7S+GhwawZ7jvmKAOogqWriYg4ubc/su/gpl01N2jx+fL0rRyTg5Zi4uPXaVSGiPYKw== X-Received: by 2002:a05:6512:3f06:b0:512:8d30:6dce with SMTP id y6-20020a0565123f0600b005128d306dcemr14162544lfa.52.1708582446477; Wed, 21 Feb 2024 22:14:06 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id u7-20020a7bc047000000b0040fe4b733f4sm4867924wmc.26.2024.02.21.22.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 22:14:06 -0800 (PST) Date: Thu, 22 Feb 2024 09:14:02 +0300 From: Dan Carpenter To: Davidlohr Bueso Cc: Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Robert Richter , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] cxl/hdm: Clean up a debug printk Message-ID: <3d3d969d-651d-4e9d-a892-900876a60ab5@moroto.mountain> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Smatch complains that %pa is for phys_addr_t types and "size" is a u64. drivers/cxl/core/hdm.c:521 cxl_dpa_alloc() error: '%pa' expects argument of type 'phys_addr_t*', argument 4 has type 'ullong* Looking at this, to me it seems more useful to print the sizes as decimal instead of hex. Let's do that. Signed-off-by: Dan Carpenter Reviewed-by: Dave Jiang Reviewed-by: Fan Ni --- drivers/cxl/core/hdm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c index 7d97790b893d..0b1843631b26 100644 --- a/drivers/cxl/core/hdm.c +++ b/drivers/cxl/core/hdm.c @@ -518,9 +518,9 @@ int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size) } if (size > avail) { - dev_dbg(dev, "%pa exceeds available %s capacity: %pa\n", &size, + dev_dbg(dev, "%llu exceeds available %s capacity: %llu\n", size, cxled->mode == CXL_DECODER_RAM ? "ram" : "pmem", - &avail); + (u64)avail); rc = -ENOSPC; goto out; }