From patchwork Tue Dec 17 05:12:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Popple X-Patchwork-Id: 13911087 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2055.outbound.protection.outlook.com [40.107.220.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C711DD0E1; Tue, 17 Dec 2024 05:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734412465; cv=fail; b=aRvJ6gHi7D2/8cal/mUwDsmHo8F0naSSog1OSYnBdhLrIJY4Pu0ltFgZte03DkPtcXelJth06W4uZZaJzUILoEziICASxH/Ur+iVIID75evnHOfE2BE8KLNMaaDVkh8glp/OQUCYcUhzmCO8L7Vdh8W1XFlkC9lchd+qyX+RNtA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734412465; c=relaxed/simple; bh=N+51V8lACYEWubyNQjC34oHstVRuzL6ZspnPk3qEV2g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=NugUGeheUoKbfgjHCgWBiHH1V/skKHkiyuNPDEkB2OvPK4jMhtZxc46rUFuSmBZnj96PMTcap9rb3uKBdgsSqCOwU1z/NAwuPN0M+69xKHbT7AhiXlZvFknFIz7tc237SVG7M4tszLJTKoQdc3Kw0r2TRBJExvjqxU5t4N8KRVI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=robvJ7UX; arc=fail smtp.client-ip=40.107.220.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="robvJ7UX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZuhAM4Lz3Lzkh59oZymTxkTQb/yV6rdBlqoY5Vt4hvXq5zzOBADgffLYZZ4h+Y91XpPgn50XXHJdSCovO3Qff/Xq6uE2bRG2MCyUQu9n/e64e4BmB5OKRBFLcKbZcPh+veVdf8siZ3HiR+W+huvY63712MD+muFLidjP12iV56e7xwThfeLXco1/dsC8bb3N1eZL3quw4ngezfux4kDQDrr3xU/Jrn+dxY/kFjGXw0ok7YBTD2Hu/gMn/rJB6wVDfM8HViRfB8vQGH41P2BUNPS2WEIhj7cAwO1FGJrpdql7I0Ys/a28iqI4/Vr1cPDTQ8+dnPeuU3BxrMFfwHQnDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rWLD/0xp0BR6MUjdXJUQ+QA/Pxu3/82VW88rj0w5N0E=; b=Q2/e3YmzJHJxz7CHu6bw07MCFUz9gY4CH5w657r8DGXbUrUCbXbQPHWuU81+O8y/S3x+ISQV9LJu/tcvxsoTqC9mlGqaAwv1nYyubJyCpchx6bsNxmmOKSax9o4mCkX8ZKETAS2V1B3xKRpcUlFdPgTVNLshMeSwDeEXWA7NCOy5yUb2KZHKtUczC1tRnS+xtw3xknLDIHolONn+DCJBiYphEIdvABgVXiwGDljlzRZ3WpOh6uqEQzrYjs1R7Lg/RSz0PGH0kwS/JxyLfodoFKgMR5z5iO+nt+w2+1b7eEpKnTY5vhTeyeM7u3z3gRL8D0fo97RnDmAs4qT4qmiL9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rWLD/0xp0BR6MUjdXJUQ+QA/Pxu3/82VW88rj0w5N0E=; b=robvJ7UX4m02ou1t8/5gJJxqgqpgOa8hm+sKcitjmnnESl6NsnLDQYg6K5Hek3L1CV3S3lVOOUe7gc2iNcPgCTaWwLby8LWASzaimFnTOv2l/9FvPTbsrmP4Wjo3WMg26tPv8QD7Lglaxhh+orNmPTS/eVXuffFWGK1YUSZG37CcqPIRapI6lz3saF+M07y43E9HUa6WOAbWmSKWYLzYORjx8hBxCCZMTKXqlDCfknCyLZdGME3s6o4ff2UE4DquhaDsWAWbabzAXuU5huyr0Zpt6GXUvRjF3LdlIF+ARbjahFmhfK35lS4u8lAXskEFqGa429QBSkyJr1zomq2xzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by CH3PR12MB8936.namprd12.prod.outlook.com (2603:10b6:610:179::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.22; Tue, 17 Dec 2024 05:14:22 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%4]) with mapi id 15.20.8251.015; Tue, 17 Dec 2024 05:14:22 +0000 From: Alistair Popple To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alistair Popple , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, Jason Gunthorpe Subject: [PATCH v4 09/25] mm/gup.c: Remove redundant check for PCI P2PDMA page Date: Tue, 17 Dec 2024 16:12:52 +1100 Message-ID: <3f20b8d258d4eb72e1eadd5926d892bc61f0e0d4.1734407924.git-series.apopple@nvidia.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: X-ClientProxiedBy: SYAPR01CA0043.ausprd01.prod.outlook.com (2603:10c6:1:1::31) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|CH3PR12MB8936:EE_ X-MS-Office365-Filtering-Correlation-Id: a3f9a3d2-d41e-4f69-cf41-08dd1e59aab0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016; X-Microsoft-Antispam-Message-Info: KeXdUNMXcMsffmqLV9xai82k9RB04qFYy6FM0459edjpdfrwrFxHFmcrPjFgpcFzrHAT6nldxRu0GDOwxaLS/wNSqmoAUpoR7FBsy+s+2+at4vni1uNIbz4bRZd0UOzteWy4X85GwtCCCzaRd/NfKtWbRd3NzplYahNIgRh5nkcyssAh0T6cQQuOXk/uSISoIhpO58NAEtkCnRwn9Wxrh0tGBLDhU6rUdhAt/syKTuoPG7S2aIuyJzxxr6ot+nDkyWkiT+EhdZr0NoK9nMObY1jFdO2zL4sEUhZAus5ClRw/e/XDWo9EZKtJXv3OqNaN+vciaLLQQg+BK7sauALve4sBtlT5GCjd1ms7SkyaWPJZRoe4zumnE9w8YyNiCcubkxverJuV90qy62SJ3MqoTz6LAJP3sLU+X73QWhmUwC1tu19Dqf1NMVcTj6V6UfPvHEFyiBZI92zHHANHNDKJg8qk2DUI0QQGo5JAZ9CXjlGgoVlGD3Do6nhU+VSSiXchB3umJL5FrEYTO/OP5/cFFe7QuPUoXSZVsrORqRaZzZnWVfcbELQj4PtrOjQ4Z3/+RFfE7j4kSU4CljLREhSEWtyH4UtaUxw3qkr1mZbK6ieFzP/Ai4oh4zCdePpQtsFaemn1mSntcF6AGnLBagw6heLV0vTLF+KTDzypvWB2BBoUHymAPKTC2ZcXL4SKmNHbcVFCFl8aVARgWIP8Usi/YizZkX6az2rrbLjVba3tt+itxb6SBhlIx43ZIYyC5JiOwyXZ6sCo3TTRAlkPm+Fnjmo20ZqhAErN6tX/ihQLB/QljGPtobfIgsuxfXdIqWRBJQQi7CyVAHp+/Bemt6ZP+uh9qOYMk97YY8FryltMe7E2n5sn6F0QjThWZzRddOMkDrgOCMsaOtiZkh3X2fAl6rIdYgUbHEXQ9xOz98VzINvhTLxF4h+mOJt/JJXY4Di2bCDRE1T1SVVmhvRYQcIdv6XGgjS9MHNFvzy33Y1aWswB7XNmQJJj54xV8twRa198kV40uLMI9pcwOPJcgFadxVe26ztUmohXzZA0+v5wYwEWoYiRR95gG7Z1dFKSb5KJ8eFXu/nf8d4W+FPWkZNz4clrlB4OnLvS5XRflnS9jTR90RPeSRwsK2XmwKdclmb8upg/GrLotqwUg0Sc77GnFS8W02ZiwczW8rpJ7JzdbHO/9zs4ntxPsxDcQ4F1FsSwpd/C08+yoIO9mqUkTxAv73NbUDoIFK7Nbny0ijcVTvE71vzlNHqf6bjjECHkyM2JWP5oNt+YDzf1XrAvqFjjmDLeDLWwRcoJy5sNS1iFt2nFmsuCD/IOm95zTaecbu6Wls/mGggp46JIBnreWRce0aPfVA+U7MYET/RdbOzdz5lqZ3O7yY8g9TZbYgLmXjV4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WBoQrfBQeZmgmNQcOX4zvM+MvaGtbXdAx65MIguRpaPV9yWKIMfJ7tQl3Fg+90g0i1eLZJPLEj9cjkDN9NeAD3COIVz+zBCVvkpgaVu2EDb3Y5QPMb9YVhkHByvjv6Fu7DOLVHyPEevZMudZYyWF6pOshjSaO8OHSmNhtcXX+K70unyPY7z9GtHyLzCEnxLU/HPxtZudRjJVPDI0wqTqb77s/fCBDvtylRxP0qBqusauU+f6NSFVHM+5Wa6Vjj0voHtrlgto9YJ8U1O3dTxhcy+sqAXMy5YNSvmeRsDMJyJcjTrjgevC59zwgCBYoScjLwtsrAtiJu2eJJc6Xm9YsWy88q26lUNj40CfhBmePwTk2axAnTFvGC5rLzbADkBipZWN6VOJcHkcbgs/ZVeIIqasjwnce3BrS20CbaGZfFsv/plv9HpSnzgZqDOGEfIR+XVXZzlQlcfH38l36Wdz4HTAddAWNJFnJIdCJviKg/ALyJNEgHAz3f6nk9K59zgI+akKdjI67wRPn7Zp0ZdAPOMpr3t7FZBfHkqyFzDVsroILZdX9SQrEr27A3VippZp5CtDGbrw7WLdNsRdJ0nqS16Ulv47nkHFW3D/l5iQe1oyJ7tbkFC/OA3FNZI+f0/5JJyOIttSdQYRC5Nm90/sD5wR9SbOH5/OK4AgrWnNimr/vZss7lBVydSbAVxrYo0RF3TR6hi0GwjZDWuxj4h88A11n01GpTgA6w3nth2InyUR1ZmFvbSUG2GVA8HKVlDlftlrTR5tU2v1i9x+s45S/5IgNagJ69ODd3x0rvc8orULaHJioIIn9FtMtPMhiAFv6zy+L33PvsKgQcF6R9vLol9KPjknzg7QnUj8Gm+jr9S6Q13BDEYtFeXdyCxt2B3cDxGITk2A5f1lN7KN0qw7cZ2yawegPWYhtKLJRl6fLYLnd8lhajJ8U3k4UudSpXWxoSOh8h6N80ywRyZGOyNZNCtsdDEai/DPASlL5Q2YslEj5/0ZIukx/PHPgc968M9pzgWbvSrJWgjsblQOoHbWS8k7Eb5lAH9HO60HtEUsZHNksD2DBPXqpfu5Jh/cksQy7h04nG4/C87Y50pyqo1jtsbskrcXduooFyQMeDD71g8pp2+2GPcgrb+NTzGUMBVwD57zENxVtSn2v1G2QkYVzAP82W8l7LHHwmz2kvw1GkSMuUsvdV8KTp+G7JZyY1e/aT4ZUgMKiejQjDFCQYtnIltUswkoA5RM9S48QUS2/LCsa/+AKWu/GRTK1kzUwiTG/dVs5KtbNvVSpX+69Jcx6TTOeDlGEMYDeUEesGoeiPgzafhT+HZZzeKUyFLAiAXR1U84uBCMX9ZAPC0VxwIMWLYPCiAZZvgUpMy3+zzj6SpzyJjvujzr9UZmapSYMnuhptYaYktbNV0UBj2Qb/5R/FCcSXvMghJeqjxzqPOy7UuGKJoT4Qh1TBieS1JdJ+csjzqMlB5F5Ly98vDebaJ2LuJaZRmzFSU9kyfxKRpi9SBZH8nGnv0QTlh6X49SmN5LwU3/HFOfY2h0GyxcFMDvAQiEyFPTxlt3cewmpFX+5WKNRhCB5pYpSMfLuSR4Fqjt X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3f9a3d2-d41e-4f69-cf41-08dd1e59aab0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2024 05:14:22.2245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UPj3/J6ZZvczFuiRCWVB0Ngx7fpRmpSVxMqP8vhMMljvOpS/6xepKzVErcVcxLNsIy8Xs8wegRtq3Yt5NF/4Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8936 PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the check in __gup_device_huge() is redundant. Remove it Signed-off-by: Alistair Popple Reviewed-by: Jason Gunthorpe Reviewed-by: Dan Wiliams Acked-by: David Hildenbrand --- mm/gup.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 2304175..9b587b5 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -3016,11 +3016,6 @@ static int gup_fast_devmap_leaf(unsigned long pfn, unsigned long addr, break; } - if (!(flags & FOLL_PCI_P2PDMA) && is_pci_p2pdma_page(page)) { - gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages); - break; - } - folio = try_grab_folio_fast(page, 1, flags); if (!folio) { gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages);