| Message ID | Yv2UeCIcA00lJC5j@bombadil.infradead.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ndctl] meson.build: be specific for library path | expand |
On Wed, 2022-08-17 at 18:23 -0700, Luis Chamberlain wrote: > If you run the typical configure script on a typical linux software > project say with ./configure --prefix=/usr/ then the libdir defaults > to /usr/lib/ however this is not true with meson. > > With meson the current libdir path follows the one set by the prefix, > and so with the current setup with prefix forced by default to /usr/ > we end up with libdir set to /usr/ as well and so libraries built > and installed also placed into /usr/ as well, not /usr/lib/ as we > would typically expect. > > So you if you use today's defaults you end up with the libraries > placed > into /usr/ and then a simple error such as: > > cxl: error while loading shared libraries: libcxl.so.1: cannot open > shared object file: No such file or directory > > Folks may have overlooked this as their old library is still usable. > > Fix this by forcing the default library path to /usr/lib, and so > requiring users to set both prefix and libdir if they want to > customize both. > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > --- > meson.build | 1 + > 1 file changed, 1 insertion(+) Hi Luis, This sounds reasonable, but I've not observed the behavior you described unless I'm missing something in my quick test. Both before and after this patch, the default path for the library for me was /usr/lib64. This is on Fedora 36 with meson 0.62.2. > > diff --git a/meson.build b/meson.build > index aecf461..802b38c 100644 > --- a/meson.build > +++ b/meson.build > @@ -9,6 +9,7 @@ project('ndctl', 'c', > default_options : [ > 'c_std=gnu99', > 'prefix=/usr', > + 'libdir=/usr/lib', > 'sysconfdir=/etc', > 'localstatedir=/var', > ],
On Fri, Aug 19, 2022 at 06:26:46AM +0000, Verma, Vishal L wrote: > On Wed, 2022-08-17 at 18:23 -0700, Luis Chamberlain wrote: > > If you run the typical configure script on a typical linux software > > project say with ./configure --prefix=/usr/ then the libdir defaults > > to /usr/lib/ however this is not true with meson. > > > > With meson the current libdir path follows the one set by the prefix, > > and so with the current setup with prefix forced by default to /usr/ > > we end up with libdir set to /usr/ as well and so libraries built > > and installed also placed into /usr/ as well, not /usr/lib/ as we > > would typically expect. > > > > So you if you use today's defaults you end up with the libraries > > placed > > into /usr/ and then a simple error such as: > > > > cxl: error while loading shared libraries: libcxl.so.1: cannot open > > shared object file: No such file or directory > > > > Folks may have overlooked this as their old library is still usable. > > > > Fix this by forcing the default library path to /usr/lib, and so > > requiring users to set both prefix and libdir if they want to > > customize both. > > > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > > --- > > meson.build | 1 + > > 1 file changed, 1 insertion(+) > > Hi Luis, > > This sounds reasonable, but I've not observed the behavior you > described unless I'm missing something in my quick test. > > Both before and after this patch, the default path for the library for > me was /usr/lib64. This is on Fedora 36 with meson 0.62.2. FWIW, my results was with debian testing. I see this is now merged, great, thanks. Luis
diff --git a/meson.build b/meson.build index aecf461..802b38c 100644 --- a/meson.build +++ b/meson.build @@ -9,6 +9,7 @@ project('ndctl', 'c', default_options : [ 'c_std=gnu99', 'prefix=/usr', + 'libdir=/usr/lib', 'sysconfdir=/etc', 'localstatedir=/var', ],
If you run the typical configure script on a typical linux software project say with ./configure --prefix=/usr/ then the libdir defaults to /usr/lib/ however this is not true with meson. With meson the current libdir path follows the one set by the prefix, and so with the current setup with prefix forced by default to /usr/ we end up with libdir set to /usr/ as well and so libraries built and installed also placed into /usr/ as well, not /usr/lib/ as we would typically expect. So you if you use today's defaults you end up with the libraries placed into /usr/ and then a simple error such as: cxl: error while loading shared libraries: libcxl.so.1: cannot open shared object file: No such file or directory Folks may have overlooked this as their old library is still usable. Fix this by forcing the default library path to /usr/lib, and so requiring users to set both prefix and libdir if they want to customize both. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- meson.build | 1 + 1 file changed, 1 insertion(+)