diff mbox series

ndctl-v77: LIBCXL_5 not found

Message ID ZFpnIICkh3Wpqmn/@minwoo-desktop
State Rejected
Headers show
Series ndctl-v77: LIBCXL_5 not found | expand

Commit Message

Minwoo Im May 9, 2023, 3:30 p.m. UTC
Hello ndctl,

With the recent tag (v77), after building it with the following
commands, `cxl` command is not albe to find `LIBCXL_5` version from the
/lib/libcxl.so.1 installed.

	meson build
	ninja -C build
	meson install -C build

	root@vm:~/work/ndctl.git# cxl
	cxl: /lib/libcxl.so.1: version `LIBCXL_5' not found (required by cxl)
	root@vm:~/work/ndctl.git# ls -l /lib/libcxl.so.1
	lrwxrwxrwx 1 root root 15 May  9 15:28 /lib/libcxl.so.1 -> libcxl.so.1.1.3

I'm not pretty certain how to go through with this, but I'm using v77
with the following patch which might not be a good one to solve it.


---


It would be great if any folks here can provide advices on this.

Thanks,

Comments

Verma, Vishal L May 9, 2023, 7:23 p.m. UTC | #1
On Wed, 2023-05-10 at 00:30 +0900, Minwoo Im wrote:
> Hello ndctl,
> 
> With the recent tag (v77), after building it with the following
> commands, `cxl` command is not albe to find `LIBCXL_5` version from the
> /lib/libcxl.so.1 installed.
> 
>         meson build
>         ninja -C build
>         meson install -C build
> 
>         root@vm:~/work/ndctl.git# cxl
>         cxl: /lib/libcxl.so.1: version `LIBCXL_5' not found (required by cxl)
>         root@vm:~/work/ndctl.git# ls -l /lib/libcxl.so.1
>         lrwxrwxrwx 1 root root 15 May  9 15:28 /lib/libcxl.so.1 -> libcxl.so.1.1.3
> 
> I'm not pretty certain how to go through with this, but I'm using v77
> with the following patch which might not be a good one to solve it.
> 
> 
> ---
> diff --git a/meson.build b/meson.build
> index 50e83cf770a2..665b8e958178 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -307,7 +307,7 @@ LIBDAXCTL_AGE=5
> 
>  LIBCXL_CURRENT=5
>  LIBCXL_REVISION=0
> -LIBCXL_AGE=4
> +LIBCXL_AGE=5
> 
>  root_inc = include_directories(['.', 'ndctl', ])

No, this patch would violate libtool versioning rules[1].

LIBCXL_5 should be available if the library has been rebuilt, it seems
like your cxl tool is picking up an older version of the library, maybe
installed via the package manager or something?

Can you try a full clean rebuild?

[1]: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> 
> 
> 
> It would be great if any folks here can provide advices on this.
> 
> Thanks,
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index 50e83cf770a2..665b8e958178 100644
--- a/meson.build
+++ b/meson.build
@@ -307,7 +307,7 @@  LIBDAXCTL_AGE=5

 LIBCXL_CURRENT=5
 LIBCXL_REVISION=0
-LIBCXL_AGE=4
+LIBCXL_AGE=5

 root_inc = include_directories(['.', 'ndctl', ])