From patchwork Sat Dec 15 17:49:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Ospite X-Patchwork-Id: 10732283 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 371CE17E9 for ; Sat, 15 Dec 2018 17:49:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28BF0288B3 for ; Sat, 15 Dec 2018 17:49:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0D1F72A222; Sat, 15 Dec 2018 17:49:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7089C2A20F for ; Sat, 15 Dec 2018 17:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729118AbeLORtj (ORCPT ); Sat, 15 Dec 2018 12:49:39 -0500 Received: from mail.ao2.it ([92.243.12.208]:37563 "EHLO ao2.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726641AbeLORti (ORCPT ); Sat, 15 Dec 2018 12:49:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ao2.it; s=20180927; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=3qx8jD++Lim7jFU23lVAapV0Ci92zd4/7COxhosmYQk=; b=oHeXCcH2g+V2KdtY2zEN5fgjNzU2oaummqf/BBKRMclOZe2A/X0gKe5m6o2xEvgs9ZxsxXUlZswoouJzw7wInu79fBUgtrdbExGk1sXZ86FLm02eu1mDoJlxLvLyne1Iq7bido21CCa7BWyCZNJ4qDKWQCTuJKwmxAoKwDTvKj7lqAeIafguYB9ZS/w/ncMvMKGYA2fHatDp4LvMt5KrPLaJbaq8XeQHtJNEyt2+v0nMAA9N4zHHo6q7N2UQgNXCsuj0DutCsG3gTnNK9f/R4g2GwExJx3vqyImCAxgrGe0aW9Z1yNh7rbmT2zrbE23VhnPKmgcDmaBcV9hlbZFoQQ==; Received: from localhost ([::1] helo=jcn) by ao2.it with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1gYE3S-00017e-GK; Sat, 15 Dec 2018 18:48:46 +0100 Received: from ao2 by jcn with local (Exim 4.91) (envelope-from ) id 1gYE4E-00032R-Fz; Sat, 15 Dec 2018 18:49:34 +0100 From: Antonio Ospite To: dash@vger.kernel.org Cc: Antonio Ospite Subject: [PATCH 0/2] Fixing clang compilation warnings Date: Sat, 15 Dec 2018 18:49:30 +0100 Message-Id: <20181215174932.11635-1-ao2@ao2.it> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Face: z*RaLf`X<@C75u6Ig9}{oW$H;1_\2t5)({*|jhM/Vb;]yA5\I~93>J<_`<4)A{':UrE Sender: dash-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dash@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, now that silent rules are in place it is also easier to spot compilation warnings with clang (CC=clang ./configure && make), so let's fix these as they seem pretty straightforward. The two patches in this series fix two classes of clang warnings, so that dash can now compile cleanly with it too. This also makes the output of "scan-build make" more usable, however fixing the issues found by the static analyzer is not something I am going to work on anytime soon. Ciao, Antonio Antonio Ospite (2): Fix clang warnings about "string plus integer" Fix clang warnings about GNU old-style field designator src/eval.c | 3 ++- src/jobs.c | 3 ++- src/output.c | 12 ++++++------ 3 files changed, 10 insertions(+), 8 deletions(-)