From patchwork Fri Sep 7 08:34:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrej Shadura X-Patchwork-Id: 10592267 X-Patchwork-Delegate: herbert@gondor.apana.org.au Delivered-To: konstantin@linuxfoundation.org Received: by 2002:a0c:fb06:0:0:0:0:0 with SMTP id c6-v6csp1459408qvp; Fri, 7 Sep 2018 01:35:07 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ9kgJJ6VUOPn69gk+KodvP1oqafsMuWpV8qy1QwRoeDbZxllwrUWr+t3y+nFYuwmwxwBOy X-Received: by 2002:a17:902:b947:: with SMTP id h7-v6mr6887334pls.157.1536309307348; Fri, 07 Sep 2018 01:35:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536309307; cv=none; d=google.com; s=arc-20160816; b=M+52k7VEBOt644u6TEEBjPAIz8SYroOtjqSvW0/6cOOrNBRzF1r9y9ytfmPVyj5qQj JMH62892v4VgZrn128iQ0u/VSyP2Y43JYSpa6QWb3lhYqePdPknftMFgvHUjPlkB3Im2 hQHqh3ANC+GoaiZg/LDiUTdyiugJFDlTvbArz4+2DMwIrYK2ZL3kyUjzUERTCF+JgdGh Z59E3vl/x3kui4nSrIICHaUc7ig+Gt0nuvRdDsS6EmlrGJVgDfNE8E4mf7GUzzJO8Whi 653OBv/3bBgLnfaWCg7QVw/i8m8+3JgEpGDNHu3ptEPNRacqAIKOK7ETMDpWAajwcl6l 2I5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:to:from; bh=9V6QKBkTcnK3nsSe/F15TsDv6hFr3wUmmGISwDb2FJc=; b=FcYAKEro1/UN8iVG2j7HBL8ckTxn5f6Qae5IfV6L09Zzx81nbtaIDePA4UB8rippun nYrQ2IcK3pls1ZihrCNBnRv6kI157jOxbkotdVJFok9ksV5GSHOID8ozdz+1NA2NS+sL HiHEsOFsQuO2DsRFPPPpjHcVyYE5TSidrYky/K0E9PPVgkMq5IuCZu3Ncv6Ac50eolQ2 NPNZvMpCdCghTeCD9Ui+o769F/hnVydACHBIJzmrACrrc6CuhMXSrx8k/wnKMARYYsKn zjNuc/GrnIFyuykBY3p317WpMBhwL1n8k0r0oouAMlIpC16vvvCdUU1kwxsFFIAeJIOc mFpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dash-owner@kernel.org designates 198.145.29.98 as permitted sender) smtp.mailfrom=dash-owner@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Return-Path: Received: from mail.wl.linuxfoundation.org (mail.wl.linuxfoundation.org. [198.145.29.98]) by mx.google.com with ESMTPS id e18-v6si7731976pgi.133.2018.09.07.01.35.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 01:35:07 -0700 (PDT) Received-SPF: pass (google.com: domain of dash-owner@kernel.org designates 198.145.29.98 as permitted sender) client-ip=198.145.29.98; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dash-owner@kernel.org designates 198.145.29.98 as permitted sender) smtp.mailfrom=dash-owner@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B2D42ADD8 for ; Fri, 7 Sep 2018 08:35:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7FB732ADE1; Fri, 7 Sep 2018 08:35:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3ADD62ADD8 for ; Fri, 7 Sep 2018 08:35:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F2472ADE1; Fri, 7 Sep 2018 08:35:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7D402ADD8 for ; Fri, 7 Sep 2018 08:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbeIGNO4 (ORCPT ); Fri, 7 Sep 2018 09:14:56 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:35248 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727848AbeIGNO4 (ORCPT ); Fri, 7 Sep 2018 09:14:56 -0400 Received: from localhost (2a02-ab04-03b9-5e00-0000-0000-0000-0003.dynamic.v6.chello.sk [IPv6:2a02:ab04:3b9:5e00::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: andrewsh) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1B0C327D872; Fri, 7 Sep 2018 09:35:03 +0100 (BST) From: Andrej Shadura To: dash@vger.kernel.org Subject: [PATCH 5/6] eval: Report I/O error on stdout Date: Fri, 7 Sep 2018 10:34:13 +0200 Message-Id: <20180907083414.14673-6-andrew.shadura@collabora.co.uk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180907083414.14673-1-andrew.shadura@collabora.co.uk> References: <20180907083414.14673-1-andrew.shadura@collabora.co.uk> Sender: dash-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dash@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP X-Virus-Scanned: ClamAV using ClamSMTP Status: O Content-Length: 1188 Lines: 46 From: Gerrit Pape ENOSPC as a result of an echo builting failing gives no diagnostic. Just as other shells, dash sets $? to 1, but aside from terminating the script, this does not inform the user what the problem is: zsh: % echo foo > /dev/full echo: write error: no space left on device bash: $ echo foo > /dev/full bash: echo: write error: No space left on device dash: $ echo foo > /dev/full [nothing] Print an error to stderr like the other shells. Suggested by Roger Leigh. Signed-off-by: Gerrit Pape [reworded the patch description with information from the bug] Signed-off-by: Andrej Shadura Bug-Debian: http://bugs.debian.org/690473 --- src/eval.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/eval.c b/src/eval.c index ee43fa9..231d3e0 100644 --- a/src/eval.c +++ b/src/eval.c @@ -955,6 +955,8 @@ evalbltin(const struct builtincmd *cmd, int argc, char **argv, int flags) else status = (*cmd->builtin)(argc, argv); flushall(); + if (outerr(out1)) + warnx("%s: I/O error", commandname); status |= outerr(out1); exitstatus = status; cmddone: