| Message ID | 1537571127-10143-1-git-send-email-bmarzins@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Misc Multipath patches | expand |
Hi Ben, this v3 patchset is ready for merge or do you plan a v4 ? Thanks, Christophe On Sat, Sep 22, 2018 at 1:05 AM Benjamin Marzinski <bmarzins@redhat.com> wrote: > This batch of patches is a resend of the non-merged pathes from my last > set, along with 2 new ones. It would be really great if we could get > a version bug after the outstanding commits go it. > > Patches 0001-0005 are a number of fixes to the tur checker.These are > the ones that should get the most attention. > Patches 0006-0017 are minor issues found by coverity. > Not all of them are bugs that could actually occur in practice, > but they are simple and hopefully non-controversial changes. > Patches 0018-0019 are new and related to changing path wwids > > Changes in v3 > added patches 0018-0019 > > Changes in v2 > 0002-libmultipath-fix-tur-checker-double-locking.patch now sets > ct->devt when initially creating the tur_checker_context, while > that structure is still only referenced by a local variable. > After that, ct->devt is only ever read. This should remove any > issues with it needing locking. > > Benjamin Marzinski (19): > libmultipath: fix tur checker timeout > libmultipath: fix tur checker double locking > libmultipath: fix tur memory misuse > libmultipath: cleanup tur locking > libmultipath: fix tur checker timeout issue > libmultipath: fix set_int error path > libmultipath: fix length issues in get_vpd_sgio > libmultipath: _install_keyword cleanup > libmultipath: remove unused code > libmultipath: fix memory issue in path_latency prio > libmultipath: fix null dereference int alloc_path_group > libmutipath: don't use malformed uevents > multipath: fix max array size in print_cmd_valid > multipathd: function return value tweaks > multipathd: minor fixes > multipathd: remove useless check and fix format > multipathd: fix memory leak on error in configure > libmultipath: Don't blank intialized paths > libmultipath: Fixup updating paths > > libmultipath/checkers/tur.c | 168 > +++++++++++-------------------- > libmultipath/dict.c | 5 +- > libmultipath/discovery.c | 18 ++-- > libmultipath/parser.c | 12 ++- > libmultipath/print.c | 8 -- > libmultipath/prioritizers/path_latency.c | 3 +- > libmultipath/structs.c | 2 +- > libmultipath/uevent.c | 6 ++ > multipath/main.c | 2 +- > multipathd/cli_handlers.c | 11 +- > multipathd/main.c | 50 +++++---- > 11 files changed, 131 insertions(+), 154 deletions(-) > > -- > 2.7.4 > > <div dir="ltr">Hi Ben,<div><br></div><div>this v3 patchset is ready for merge or do you plan a v4 ?</div><div><br></div><div>Thanks,</div><div>Christophe</div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Sep 22, 2018 at 1:05 AM Benjamin Marzinski <<a href="mailto:bmarzins@redhat.com">bmarzins@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This batch of patches is a resend of the non-merged pathes from my last<br> set, along with 2 new ones. It would be really great if we could get<br> a version bug after the outstanding commits go it.<br> <br> Patches 0001-0005 are a number of fixes to the tur checker.These are<br> the ones that should get the most attention.<br> Patches 0006-0017 are minor issues found by coverity.<br> Not all of them are bugs that could actually occur in practice,<br> but they are simple and hopefully non-controversial changes.<br> Patches 0018-0019 are new and related to changing path wwids<br> <br> Changes in v3<br> added patches 0018-0019<br> <br> Changes in v2<br> 0002-libmultipath-fix-tur-checker-double-locking.patch now sets<br> ct->devt when initially creating the tur_checker_context, while<br> that structure is still only referenced by a local variable.<br> After that, ct->devt is only ever read. This should remove any<br> issues with it needing locking.<br> <br> Benjamin Marzinski (19):<br> libmultipath: fix tur checker timeout<br> libmultipath: fix tur checker double locking<br> libmultipath: fix tur memory misuse<br> libmultipath: cleanup tur locking<br> libmultipath: fix tur checker timeout issue<br> libmultipath: fix set_int error path<br> libmultipath: fix length issues in get_vpd_sgio<br> libmultipath: _install_keyword cleanup<br> libmultipath: remove unused code<br> libmultipath: fix memory issue in path_latency prio<br> libmultipath: fix null dereference int alloc_path_group<br> libmutipath: don't use malformed uevents<br> multipath: fix max array size in print_cmd_valid<br> multipathd: function return value tweaks<br> multipathd: minor fixes<br> multipathd: remove useless check and fix format<br> multipathd: fix memory leak on error in configure<br> libmultipath: Don't blank intialized paths<br> libmultipath: Fixup updating paths<br> <br> libmultipath/checkers/tur.c | 168 +++++++++++--------------------<br> libmultipath/dict.c | 5 +-<br> libmultipath/discovery.c | 18 ++--<br> libmultipath/parser.c | 12 ++-<br> libmultipath/print.c | 8 --<br> libmultipath/prioritizers/path_latency.c | 3 +-<br> libmultipath/structs.c | 2 +-<br> libmultipath/uevent.c | 6 ++<br> multipath/main.c | 2 +-<br> multipathd/cli_handlers.c | 11 +-<br> multipathd/main.c | 50 +++++----<br> 11 files changed, 131 insertions(+), 154 deletions(-)<br> <br> -- <br> 2.7.4<br> <br> </blockquote></div> -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Sun, Oct 07, 2018 at 10:36:41AM +0200, Christophe Varoqui wrote: I'll send a v4, hopefully today. -Ben > Hi Ben, > this v3 patchset is ready for merge or do you plan a v4 ? > Thanks, > Christophe > On Sat, Sep 22, 2018 at 1:05 AM Benjamin Marzinski > <[1]bmarzins@redhat.com> wrote: > > This batch of patches is a resend of the non-merged pathes from my last > set, along with 2 new ones. It would be really great if we could get > a version bug after the outstanding commits go it. > > Patches 0001-0005 are a number of fixes to the tur checker.These are > the ones that should get the most attention. > Patches 0006-0017 are minor issues found by coverity. > Not all of them are bugs that could actually occur in practice, > but they are simple and hopefully non-controversial changes. > Patches 0018-0019 are new and related to changing path wwids > > Changes in v3 > added patches 0018-0019 > > Changes in v2 > 0002-libmultipath-fix-tur-checker-double-locking.patch now sets > ct->devt when initially creating the tur_checker_context, while > that structure is still only referenced by a local variable. > After that, ct->devt is only ever read. This should remove any > issues with it needing locking. > > Benjamin Marzinski (19): > libmultipath: fix tur checker timeout > libmultipath: fix tur checker double locking > libmultipath: fix tur memory misuse > libmultipath: cleanup tur locking > libmultipath: fix tur checker timeout issue > libmultipath: fix set_int error path > libmultipath: fix length issues in get_vpd_sgio > libmultipath: _install_keyword cleanup > libmultipath: remove unused code > libmultipath: fix memory issue in path_latency prio > libmultipath: fix null dereference int alloc_path_group > libmutipath: don't use malformed uevents > multipath: fix max array size in print_cmd_valid > multipathd: function return value tweaks > multipathd: minor fixes > multipathd: remove useless check and fix format > multipathd: fix memory leak on error in configure > libmultipath: Don't blank intialized paths > libmultipath: Fixup updating paths > > libmultipath/checkers/tur.c | 168 > +++++++++++-------------------- > libmultipath/dict.c | 5 +- > libmultipath/discovery.c | 18 ++-- > libmultipath/parser.c | 12 ++- > libmultipath/print.c | 8 -- > libmultipath/prioritizers/path_latency.c | 3 +- > libmultipath/structs.c | 2 +- > libmultipath/uevent.c | 6 ++ > multipath/main.c | 2 +- > multipathd/cli_handlers.c | 11 +- > multipathd/main.c | 50 +++++---- > 11 files changed, 131 insertions(+), 154 deletions(-) > > -- > 2.7.4 > > References > > Visible links > 1. mailto:bmarzins@redhat.com -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel