[v2,0/8] multipath cleanups

Message

Benjamin Marzinski Aug. 11, 2020, 9:58 p.m. UTC

Patches 0003 & 0004 fix an issue that I've seen with paths whose checker
takes too long when multipathd is starting up and creating devices.

The others are minor build fixes or small cleanups to my previous
patchset.

Changes in v2:
- patch 0003 no longer refactors count_active_paths(), as suggested
  by Martin Wilck
- Added patches 0007 & 0008, which are both unrelated minor changes.

Benjamin Marzinski (8):
  Makefile.inc: trim extra information from systemd version
  kpartx: fix -Wsign-compare error
  libmultipath: refactor path counting
  libmultipath: count pending paths as active on loads
  libmultipath: deal with flushing no maps
  multipath: deal with delegation failures correctly
  multipathd: unset mpp->hwe when removing map
  multipathd: log reason for calling domap()

 Makefile.inc                    |  2 +-
 kpartx/kpartx.c                 |  2 +-
 libmpathpersist/mpath_persist.c |  4 ++--
 libmultipath/devmapper.c        |  5 +++--
 libmultipath/structs.c          | 38 +++++++++++++++++++++------------
 libmultipath/structs.h          |  2 +-
 libmultipath/structs_vec.c      |  1 +
 multipath/main.c                |  9 +++++---
 multipathd/main.c               | 14 ++++++++----
 9 files changed, 49 insertions(+), 28 deletions(-)

Comments

Martin Wilck Aug. 12, 2020, 9:31 a.m. UTC | #1

On Tue, 2020-08-11 at 16:58 -0500, Benjamin Marzinski wrote:
> Patches 0003 & 0004 fix an issue that I've seen with paths whose
> checker
> takes too long when multipathd is starting up and creating devices.
> 
> The others are minor build fixes or small cleanups to my previous
> patchset.
> 
> Changes in v2:
> - patch 0003 no longer refactors count_active_paths(), as suggested
>   by Martin Wilck
> - Added patches 0007 & 0008, which are both unrelated minor changes.
> 
> Benjamin Marzinski (8):
>   Makefile.inc: trim extra information from systemd version
>   kpartx: fix -Wsign-compare error
>   libmultipath: refactor path counting
>   libmultipath: count pending paths as active on loads
>   libmultipath: deal with flushing no maps
>   multipath: deal with delegation failures correctly
>   multipathd: unset mpp->hwe when removing map
>   multipathd: log reason for calling domap()
> 
>  Makefile.inc                    |  2 +-
>  kpartx/kpartx.c                 |  2 +-
>  libmpathpersist/mpath_persist.c |  4 ++--
>  libmultipath/devmapper.c        |  5 +++--
>  libmultipath/structs.c          | 38 +++++++++++++++++++++--------
> ----
>  libmultipath/structs.h          |  2 +-
>  libmultipath/structs_vec.c      |  1 +
>  multipath/main.c                |  9 +++++---
>  multipathd/main.c               | 14 ++++++++----
>  9 files changed, 49 insertions(+), 28 deletions(-)
> 

For the series, except 7/8 "multipathd: unset mpp->hwe when removing
map":

Reviewed-by: Martin Wilck <[e-mail]>