From patchwork Thu Dec 17 22:50:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Marzinski X-Patchwork-Id: 11980953 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F46FC2BBCD for ; Thu, 17 Dec 2020 22:51:25 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B11923A24 for ; Thu, 17 Dec 2020 22:51:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B11923A24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608245484; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Bo5SUU70tO35CxH6vVtkN6YKifT0N3CynsRdDYDG54o=; b=CgFyN5LdAQtduslKHAdViVzXAfEVipjkJhnrldz70xE2qm3FIIivdmIKL6kOqZh67Jqk4A JJIe6X2eQGKXlA1oy3pHiLZmyO4PvEQ3itisZvMgqj3RiZclESOSRJ4WSpgb0tMct5zlnT 6KLKLJzNaAqCUz+r8FQ0+kvbByp4xWo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-bLJW6et0P2uleqVjXjhk8g-1; Thu, 17 Dec 2020 17:51:20 -0500 X-MC-Unique: bLJW6et0P2uleqVjXjhk8g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79ABE107ACE6; Thu, 17 Dec 2020 22:51:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4936C19EF2; Thu, 17 Dec 2020 22:51:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ECD1F4BB7B; Thu, 17 Dec 2020 22:51:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0BHMp9RG008306 for ; Thu, 17 Dec 2020 17:51:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id A43E32C8A6; Thu, 17 Dec 2020 22:51:09 +0000 (UTC) Received: from octiron.msp.redhat.com (octiron.msp.redhat.com [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 402EB1ACC7; Thu, 17 Dec 2020 22:51:05 +0000 (UTC) Received: from octiron.msp.redhat.com (localhost.localdomain [127.0.0.1]) by octiron.msp.redhat.com (8.14.9/8.14.9) with ESMTP id 0BHMp4X1001789; Thu, 17 Dec 2020 16:51:04 -0600 Received: (from bmarzins@localhost) by octiron.msp.redhat.com (8.14.9/8.14.9/Submit) id 0BHMp4Kn001788; Thu, 17 Dec 2020 16:51:04 -0600 From: Benjamin Marzinski To: Christophe Varoqui Date: Thu, 17 Dec 2020 16:50:58 -0600 Message-Id: <1608245463-1746-1-git-send-email-bmarzins@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: dm-devel@redhat.com Cc: device-mapper development , Martin Wilck Subject: [dm-devel] [PATCH v3 0/5] Misc Multipath patches X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com This is a set of unrelated patches, based on top of my previous "add library to check if device is a valid path" patchset. The first two patches add a new config option, eh_deadline, that sets the scsi sysfs value of the same name for scsi path devices. This has been requested by multiple customers. Patch 0005 is a change to detecting rdac support requested by Netapp. Changes from v2 to v3: 0004: Add size parameter to fetch_vpd_page() instead of assuming 4096, as suggested by Martin 0005: I realized that fetch_vpd_page() already correctly checked the page number and size and warned about truncation, so there was no point in checking the size again in is_vpd_page_supported(). Dropped patch 0006 in favor or Martin's approach to solving the dlclose issue. Changes from v1 to v2: 0002: multiple small fixes suggested by Martin 0004: New patch to setup for checking vpd page 0x00 0005 (was 0004): added checking for vpd page 0xc9 in vpd page 0x00, as suggested by Martin 0006 (was 0005): Added version script update Benjamin Marzinski (5): libmultipath: move fast_io_fail defines to structs.h libmultipath: add eh_deadline multipath.conf parameter multipathd: remove redundant vector_free() int configure libmultipath: factor out code to get vpd page data libmultipath: limit reading 0xc9 vpd page libmultipath/config.c | 2 + libmultipath/config.h | 10 +--- libmultipath/configure.c | 1 + libmultipath/dict.c | 40 ++++++++------ libmultipath/dict.h | 2 +- libmultipath/discovery.c | 104 +++++++++++++++++++++++++++++++------ libmultipath/discovery.h | 1 + libmultipath/propsel.c | 29 +++++++++-- libmultipath/propsel.h | 1 + libmultipath/structs.h | 24 +++++++++ multipath/multipath.conf.5 | 16 ++++++ multipathd/main.c | 8 +-- 12 files changed, 188 insertions(+), 50 deletions(-) Reviewed-by: Martin Wilck