[0/3] Multipath io_err_stat fixes

Message

Benjamin Marzinski Jan. 12, 2021, 11:52 p.m. UTC

I found an ABBA deadlock in the io_err_stat marginal path code, and in
the process of fixing it, noticed a potential crash on shutdown. This
patchset addresses both of the issues.

Benjamin Marzinski (3):
  libmultipath: make find_err_path_by_dev() static
  multipathd: avoid io_err_stat crash during shutdown
  multipathd: avoid io_err_stat ABBA deadlock

 libmultipath/io_err_stat.c | 159 +++++++++++++++++--------------------
 1 file changed, 73 insertions(+), 86 deletions(-)

Comments

Martin Wilck Jan. 13, 2021, 11:45 a.m. UTC | #1

On Tue, 2021-01-12 at 17:52 -0600, Benjamin Marzinski wrote:
> I found an ABBA deadlock in the io_err_stat marginal path code, and
> in
> the process of fixing it, noticed a potential crash on shutdown. This
> patchset addresses both of the issues.
> 
> Benjamin Marzinski (3):
>   libmultipath: make find_err_path_by_dev() static
>   multipathd: avoid io_err_stat crash during shutdown
>   multipathd: avoid io_err_stat ABBA deadlock
> 
>  libmultipath/io_err_stat.c | 159 +++++++++++++++++------------------
> --
>  1 file changed, 73 insertions(+), 86 deletions(-)
> 

Thanks, the series looks good, I have only minor nits.

I've made some remarks about the io_err_stat code in the review. While
you're working at it, would you be willing to fix those issues too?

Cheers,
Martin

Benjamin Marzinski Jan. 13, 2021, 5:09 p.m. UTC | #2

On Wed, Jan 13, 2021 at 11:45:55AM +0000, Martin Wilck wrote:
> On Tue, 2021-01-12 at 17:52 -0600, Benjamin Marzinski wrote:
> > I found an ABBA deadlock in the io_err_stat marginal path code, and
> > in
> > the process of fixing it, noticed a potential crash on shutdown. This
> > patchset addresses both of the issues.
> > 
> > Benjamin Marzinski (3):
> >   libmultipath: make find_err_path_by_dev() static
> >   multipathd: avoid io_err_stat crash during shutdown
> >   multipathd: avoid io_err_stat ABBA deadlock
> > 
> >  libmultipath/io_err_stat.c | 159 +++++++++++++++++------------------
> > --
> >  1 file changed, 73 insertions(+), 86 deletions(-)
> > 
> 
> Thanks, the series looks good, I have only minor nits.
> 
> I've made some remarks about the io_err_stat code in the review. While
> you're working at it, would you be willing to fix those issues too?

Sure. I'll send out a v2 patchset that addresses all your issues.

-Ben

> 
> Cheers,
> Martin
> 
> -- 
> Dr. Martin Wilck <[e-mail]>, Tel. [phone]
> SUSE Software Solutions Germany GmbH
> HRB 36809, AG Nürnberg GF: Felix Imendörffer
> 

--
dm-devel mailing list
[e-mail]
https://www.redhat.com/mailman/listinfo/dm-devel