From patchwork Fri May 14 20:10:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Marzinski X-Patchwork-Id: 12258873 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC1AC43461 for ; Fri, 14 May 2021 20:11:19 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F2D06145B for ; Fri, 14 May 2021 20:11:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F2D06145B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621023078; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=96sKzSju4EB78242tG5lle4PL9A7vC9y2WlJt43k+i4=; b=NPgsM4UPmXRbmP6vYy0rTnPwGS6fD08A58/XD82vet1GdbClJ43DdHAUtkQ1Dthfsj80Kk hvp+CqaY5FVj4NQgmeqDK2yI5+6q6GLsY4dKbKmqzkY4HdCXgcmCjYqgt6Adah+zbMq6mJ VTBybOLr8/EMP0KzFMtbPgL51C/3jUE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-jpUwbaJlP-Ga1IASwUkixQ-1; Fri, 14 May 2021 16:11:14 -0400 X-MC-Unique: jpUwbaJlP-Ga1IASwUkixQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 238E9FC9A; Fri, 14 May 2021 20:11:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 813CC5C1C2; Fri, 14 May 2021 20:11:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 78084180B463; Fri, 14 May 2021 20:11:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14EKB5P4010817 for ; Fri, 14 May 2021 16:11:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id D71221962F; Fri, 14 May 2021 20:11:05 +0000 (UTC) Received: from octiron.msp.redhat.com (octiron.msp.redhat.com [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 915852BFEB; Fri, 14 May 2021 20:11:02 +0000 (UTC) Received: from octiron.msp.redhat.com (localhost.localdomain [127.0.0.1]) by octiron.msp.redhat.com (8.14.9/8.14.9) with ESMTP id 14EKB03l020049; Fri, 14 May 2021 15:11:01 -0500 Received: (from bmarzins@localhost) by octiron.msp.redhat.com (8.14.9/8.14.9/Submit) id 14EKB0pw020048; Fri, 14 May 2021 15:11:00 -0500 From: Benjamin Marzinski To: Christophe Varoqui Date: Fri, 14 May 2021 15:10:54 -0500 Message-Id: <1621023060-20011-1-git-send-email-bmarzins@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: dm-devel@redhat.com Cc: device-mapper development , Martin Wilck Subject: [dm-devel] [PATCH v3 0/6] Memory issues found by coverity X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com This is collection of issues found by coverity. The first three patches deal with ev_remove_path() removing the path, but returning failure, causing a use-after-free error. The next two patches fix memory leaks. The final patch removes an unnecessary call to rescan_paths() from uev_update_path() Changes from v2: 0003: Combined with v2 patch 0006, with changes changes in comments, how the return codes are defined, and how they are handled, based on Martin's suggestions 0006: New patch based on Martin's suggestions about wwid change handling in uev_update_path(). Changes from v1: 0001: changed comment based on Martin's suggestion 0004: moved location of atexit() call based on Martin's suggestion 0006: New patch, based on Martin's comments on patch 0003 Benjamin Marzinski (6): multipathd: don't fail to remove path once the map is removed multipathd: remove duplicate orphan_paths in flush_map multipathd: fix ev_remove_path return code handling multipath: free vectors in configure kpartx: Don't leak memory when getblock returns NULL multipathd: don't rescan_path on wwid change in uev_update_path kpartx/kpartx.c | 2 ++ libmultipath/structs_vec.c | 4 +-- multipath/main.c | 7 ++++- multipathd/cli_handlers.c | 14 ++++++++-- multipathd/main.c | 56 ++++++++++++++++++++------------------ multipathd/main.h | 14 ++++++++++ 6 files changed, 65 insertions(+), 32 deletions(-)