mbox series

[v3,0/9] improving config parsing warnings

Message ID 1636656832-26062-1-git-send-email-bmarzins@redhat.com (mailing list archive)
Headers show
Series improving config parsing warnings | expand

Message

Benjamin Marzinski Nov. 11, 2021, 6:53 p.m. UTC
This is a series of patches to make multipath provide better warnings
when parsing multipath.conf. The first three patches fix small issues.
The last six patches make multipath print warning messages with
the file and line number, when it was previously either accepting
invalid values or silently changing them.

Changes from v2->v3, as suggested by Martin Wilck:
0007: still print the value of the deprecated options.
0008: revert to v1 patch

Changes from v1->v2 (by v1 patch number), as suggested by Martin Wilck:

0005: use MAX_VEROSITY enum in the verbosity handler declaration.
0006: added a new patch, 0007, to warn that these options are now
      deprecated, and no longer print them when the have the default
      value.  They are still used for now.
0007: functions that accept "0" as a special input value will now
      check if the integer gotten by do_set_int() is 0, and
      covert that to the special case.

Benjamin Marzinski (9):
  libmultipath: add section name to invalid keyword output
  libmultipath: use typedef for keyword handler function
  libmultipath: print the correct file when parsing fails
  libmultipath: pass file and line number to keyword handlers
  libmultipath: make set_int take a range for valid values
  libmultipath: improve checks for set_str
  libmultipath: deprecate file and directory config options
  libmultipath: split set_int to enable reuse
  libmultipath: cleanup invalid config handling

 libmultipath/dict.c        | 492 +++++++++++++++++++++++++------------
 libmultipath/parser.c      |  31 ++-
 libmultipath/parser.h      |  15 +-
 multipath/multipath.conf.5 |   5 +
 4 files changed, 365 insertions(+), 178 deletions(-)