From patchwork Wed Nov 17 20:33:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Marzinski X-Patchwork-Id: 12625385 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8485FC433F5 for ; Wed, 17 Nov 2021 20:33:56 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 295116135E for ; Wed, 17 Nov 2021 20:33:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 295116135E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637181235; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Mv7MZQAd5CkUFXQw5fP3AqH644aXmu49cYtUp9Erh9A=; b=Yo+GGLIh2VypKThXPofPteAGrnzGYhKx8UFNmM5tSOFMuIcl1WdGXr2WOFSNeRDfQEPtPZ K0eHu31I+DWJZl9Z4pkl74EcAUYK7MqouU3NFQoEcxv7/O4fLq7/Bu5k7nxyQ3PZK7mT7p qHTNS4+Iz+T2lk3hvol+Ccw6Sar2qNU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-wTXefBDaMsm5joFfb3SGqw-1; Wed, 17 Nov 2021 15:33:51 -0500 X-MC-Unique: wTXefBDaMsm5joFfb3SGqw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD0DA1023F4D; Wed, 17 Nov 2021 20:33:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8929519D9B; Wed, 17 Nov 2021 20:33:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B093B4E9F5; Wed, 17 Nov 2021 20:33:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AHKXgsY018115 for ; Wed, 17 Nov 2021 15:33:43 -0500 Received: by smtp.corp.redhat.com (Postfix) id F11625C232; Wed, 17 Nov 2021 20:33:42 +0000 (UTC) Received: from octiron.msp.redhat.com (unknown [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 483D95C1BB; Wed, 17 Nov 2021 20:33:40 +0000 (UTC) Received: from octiron.msp.redhat.com (localhost.localdomain [127.0.0.1]) by octiron.msp.redhat.com (8.14.9/8.14.9) with ESMTP id 1AHKXcRC004461; Wed, 17 Nov 2021 14:33:38 -0600 Received: (from bmarzins@localhost) by octiron.msp.redhat.com (8.14.9/8.14.9/Submit) id 1AHKXcpA004460; Wed, 17 Nov 2021 14:33:38 -0600 From: Benjamin Marzinski To: Christophe Varoqui Date: Wed, 17 Nov 2021 14:33:33 -0600 Message-Id: <1637181217-4423-1-git-send-email-bmarzins@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: dm-devel@redhat.com Cc: device-mapper development , Martin Wilck Subject: [dm-devel] [PATCH v2 0/4] Add "reconfigure all" multipath command X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com This patchset is supposed to replace Martin's multipathd: add "force_reconfigure" option patch from his uxlsnr overhaul patchset. It also makes the default reconfigure be a weak reconfigure, but instead of adding a configuration option to control this, it adds a new multipathd command, "reconfigure all", to do a full reconfigure. The HUP signal is left doing only weak reconfigures. In order to keep from having two states that are handled nearly identically, the code adds an extra variable to track the type of configuration that was selected, but this could easily be switch to use a new DAEMON_CONFIGURE_ALL state instead. The final patch, that added the new command, is meant to apply on top of Martin's changed client handler code. I can send one that works with the current client handler code, if people would rather review that. Changes from v1 as suggested by Martin Wilck: 0001: update libmultipath.version to handle ABI change in struct config 0003: Clarify commit message Benjamin Marzinski (4): multipathd: move delayed_reconfig out of struct config multipathd: remove reconfigure from header file. multipathd: pass in the type of reconfigure multipathd: add "reconfigure all" command. libmpathpersist/libmpathpersist.version | 12 ++-- libmultipath/config.h | 1 - libmultipath/configure.c | 2 +- libmultipath/libmultipath.version | 22 +++--- multipath/main.c | 2 +- multipathd/cli.c | 1 + multipathd/cli.h | 2 + multipathd/cli_handlers.c | 12 +++- multipathd/main.c | 91 ++++++++++++++----------- multipathd/main.h | 3 +- multipathd/multipathd.8 | 10 ++- 11 files changed, 91 insertions(+), 67 deletions(-)