mbox series

[v3,0/7] multipathd: make uxlsnr errors really fatal

Message ID 20181102122402.31145-1-mwilck@suse.com (mailing list archive)
Headers show
Series multipathd: make uxlsnr errors really fatal | expand

Message

Martin Wilck Nov. 2, 2018, 12:23 p.m. UTC
Hi Christophe,

this series, based on top of the recently submitted
"various multipath-tools patches (v2)" and "checkers overhaul (v3)"
series, fixes a problem that I recently observed: despite
ee01e841 "multipathd: handle errors in uxlsnr as fatal", multipathd
sometimes doesn't quit when the socket setup fails.

While at that, I stumbled upon init_path_check_interval(), wondered
about its purpose, and came to the conclusion that can be quite
easily obsoleted.

----
Changes v2->v3:
  04/07: Fixed cleanup code path (Ben).

Changes v1->v2:
  04/07: Fixed problem observed by Ben.

Martin Wilck (7):
  libmultipath: set pp->checkint in store_pathinfo()
  multipathd: remove init_path_check_interval()
  multipathd: print error message if checkint is not initialized
  multipathd: open client socket early
  multipathd: set DAEMON_CONFIGURE from uxlsnr thread
  multipathd: make DAEMON_SHUTDOWN a terminal state
  multipathd: only grab conf once for filter_path()

 libmultipath/defaults.h   |   1 +
 libmultipath/dict.c       |  14 ++++-
 libmultipath/discovery.c  |   1 +
 libmultipath/structs.c    |   1 +
 multipathd/cli_handlers.c |  10 ++--
 multipathd/main.c         | 109 +++++++++++++++++++++++++-------------
 multipathd/uxlsnr.c       |  14 +----
 multipathd/uxlsnr.h       |   5 +-
 8 files changed, 98 insertions(+), 57 deletions(-)

Comments

Christophe Varoqui Nov. 14, 2018, 7:38 a.m. UTC | #1
Merged.
Thanks.

On Fri, Nov 2, 2018 at 1:24 PM Martin Wilck <mwilck@suse.com> wrote:

> Hi Christophe,
>
> this series, based on top of the recently submitted
> "various multipath-tools patches (v2)" and "checkers overhaul (v3)"
> series, fixes a problem that I recently observed: despite
> ee01e841 "multipathd: handle errors in uxlsnr as fatal", multipathd
> sometimes doesn't quit when the socket setup fails.
>
> While at that, I stumbled upon init_path_check_interval(), wondered
> about its purpose, and came to the conclusion that can be quite
> easily obsoleted.
>
> ----
> Changes v2->v3:
>   04/07: Fixed cleanup code path (Ben).
>
> Changes v1->v2:
>   04/07: Fixed problem observed by Ben.
>
> Martin Wilck (7):
>   libmultipath: set pp->checkint in store_pathinfo()
>   multipathd: remove init_path_check_interval()
>   multipathd: print error message if checkint is not initialized
>   multipathd: open client socket early
>   multipathd: set DAEMON_CONFIGURE from uxlsnr thread
>   multipathd: make DAEMON_SHUTDOWN a terminal state
>   multipathd: only grab conf once for filter_path()
>
>  libmultipath/defaults.h   |   1 +
>  libmultipath/dict.c       |  14 ++++-
>  libmultipath/discovery.c  |   1 +
>  libmultipath/structs.c    |   1 +
>  multipathd/cli_handlers.c |  10 ++--
>  multipathd/main.c         | 109 +++++++++++++++++++++++++-------------
>  multipathd/uxlsnr.c       |  14 +----
>  multipathd/uxlsnr.h       |   5 +-
>  8 files changed, 98 insertions(+), 57 deletions(-)
>
> --
> 2.19.1
>
>
<div dir="ltr">Merged.<div>Thanks.</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Nov 2, 2018 at 1:24 PM Martin Wilck &lt;<a href="mailto:mwilck@suse.com">mwilck@suse.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Christophe,<br>
<br>
this series, based on top of the recently submitted<br>
&quot;various multipath-tools patches (v2)&quot; and &quot;checkers overhaul (v3)&quot;<br>
series, fixes a problem that I recently observed: despite<br>
ee01e841 &quot;multipathd: handle errors in uxlsnr as fatal&quot;, multipathd<br>
sometimes doesn&#39;t quit when the socket setup fails.<br>
<br>
While at that, I stumbled upon init_path_check_interval(), wondered<br>
about its purpose, and came to the conclusion that can be quite<br>
easily obsoleted.<br>
<br>
----<br>
Changes v2-&gt;v3:<br>
  04/07: Fixed cleanup code path (Ben).<br>
<br>
Changes v1-&gt;v2:<br>
  04/07: Fixed problem observed by Ben.<br>
<br>
Martin Wilck (7):<br>
  libmultipath: set pp-&gt;checkint in store_pathinfo()<br>
  multipathd: remove init_path_check_interval()<br>
  multipathd: print error message if checkint is not initialized<br>
  multipathd: open client socket early<br>
  multipathd: set DAEMON_CONFIGURE from uxlsnr thread<br>
  multipathd: make DAEMON_SHUTDOWN a terminal state<br>
  multipathd: only grab conf once for filter_path()<br>
<br>
 libmultipath/defaults.h   |   1 +<br>
 libmultipath/dict.c       |  14 ++++-<br>
 libmultipath/discovery.c  |   1 +<br>
 libmultipath/structs.c    |   1 +<br>
 multipathd/cli_handlers.c |  10 ++--<br>
 multipathd/main.c         | 109 +++++++++++++++++++++++++-------------<br>
 multipathd/uxlsnr.c       |  14 +----<br>
 multipathd/uxlsnr.h       |   5 +-<br>
 8 files changed, 98 insertions(+), 57 deletions(-)<br>
<br>
-- <br>
2.19.1<br>
<br>
</blockquote></div>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel