From patchwork Thu Dec 6 16:41:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Snitzer X-Patchwork-Id: 10716339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5D92814E2 for ; Thu, 6 Dec 2018 16:41:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C5882F107 for ; Thu, 6 Dec 2018 16:41:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A5002F12C; Thu, 6 Dec 2018 16:41:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E38E12F13A for ; Thu, 6 Dec 2018 16:41:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A71730B8FB7; Thu, 6 Dec 2018 16:41:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 377BC5C634; Thu, 6 Dec 2018 16:41:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 789E0181B9E4; Thu, 6 Dec 2018 16:41:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wB6GfUmN030126 for ; Thu, 6 Dec 2018 11:41:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4D88F3783; Thu, 6 Dec 2018 16:41:30 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DC84425F; Thu, 6 Dec 2018 16:41:27 +0000 (UTC) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F15DF30024ED; Thu, 6 Dec 2018 16:41:26 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id y16so682545qki.7; Thu, 06 Dec 2018 08:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=dDKxzRufLq2l/KUcjLYGwNn+V+t9xfDaF13eY9VsG18=; b=T05NLasS8PeE7g5vc0QigIvQtR31DMFVSNRDO14UxowSgsthj1wfGp0VHvbDDswuvN Jga/dHwl61OvIbhh37gDyXaywbDPNiFnNhIYH0qawXHiIy7kc057O9xA3FSeRboKp4zi Q7j8MUBKC3vFGEMoHiTHWrhlA0LdjvwtDtoPu0NhZzBfYWKh6U9c9m7l2zuhAjxdyDZ8 ZCg3RqOEICJ4N0keYRag+LdSZjNJ67bFqUm8YnlI9i0LWszEUcoskDKJQ+Jired8NVkH h6Uam428U8jMq7kqfQ93EsJNy/lrxY24AkIn9hMglUsWSM3CndlhNyOVA+jkoWXFrC4I TLSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=dDKxzRufLq2l/KUcjLYGwNn+V+t9xfDaF13eY9VsG18=; b=TZeO2YcIlEA+x264IfGFzjW/eUkmre+nURSzKUZQLNVSXCxKEe/pfLMdmhi5zbgNtY uTc44PfuZgM95AJMXkbmNIGuafYBdX5hek2qJuHc7F98vknYBHcfQAs83QckwCRCAVLX WjKxziFHnTB3g4b0Vkj2JRONTGAeNE6XwYRJYWjIN7+emlIkdhG21oYAB5UNm0M/lXVi nM+5eipodCFGz9QqWokrW9TpkDzAvqFUrRIg3WKglofxezEJPnzkxTHhGauLXh4VaSdV fJowfsJZ/VU6qt/AJNscsXqepKX6A+IbHMBsCJm59Y/L9vBEnnESuke6GBeAKbCvd+5N 5KxQ== X-Gm-Message-State: AA+aEWb6yHk2K0Z0LWS4NeHSPwE4hSh11VRbljySD/pByLhWit5NgaKZ +M6NaXaagSKQAhyu3WXwcTtPQc4E X-Google-Smtp-Source: AFSGD/W17mz4S53yZKKuqpQH//ve0SsuQHHHY2UBVtKTt4sK+JAV70LT19TkcodD1yLykQZxIBDL8Q== X-Received: by 2002:a37:34d0:: with SMTP id b199mr26373292qka.284.1544114486120; Thu, 06 Dec 2018 08:41:26 -0800 (PST) Received: from localhost (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id z30sm588863qtz.26.2018.12.06.08.41.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Dec 2018 08:41:24 -0800 (PST) From: Mike Snitzer To: Jens Axboe Date: Thu, 6 Dec 2018 11:41:15 -0500 Message-Id: <20181206164122.2166-1-snitzer@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 06 Dec 2018 16:41:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 06 Dec 2018 16:41:27 +0000 (UTC) for IP:'209.85.222.195' DOMAIN:'mail-qk1-f195.google.com' HELO:'mail-qk1-f195.google.com' FROM:'snitzer@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.091 (DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.222.195 mail-qk1-f195.google.com 209.85.222.195 mail-qk1-f195.google.com X-RedHat-Possible-Forgery: Mike Snitzer X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: dm-devel@redhat.com Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, Mikulas Patocka Subject: [dm-devel] [PATCH v4 0/7] per-cpu in_flight counters for bio-based drivers X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 06 Dec 2018 16:41:44 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP Hey, This v4 addresses the compile issues on various archs when CONFIG_SMP isn't set (by introducing appropriate wrappers in genhd.h) Testing with this v4 I was unable to reproduce the issue you reported where iostat always reports 0 for avgqu-sz -- but please let me know if you still see problems like that. Thanks, Mike Mike Snitzer (2): dm rq: leverage blk_mq_queue_busy() to check for outstanding IO block: stop passing 'cpu' to all percpu stats methods Mikulas Patocka (5): dm: dont rewrite dm_disk(md)->part0.in_flight block: delete part_round_stats and switch to less precise counting block: switch to per-cpu in-flight counters block: return just one value from part_in_flight dm: remove the pending IO accounting block/bio.c | 36 ++++++++++++++++----- block/blk-core.c | 80 +++++++---------------------------------------- block/blk-merge.c | 4 +-- block/blk-mq.c | 12 +++---- block/blk-mq.h | 3 +- block/genhd.c | 55 ++++++++++++++++++-------------- block/partition-generic.c | 10 ++---- drivers/md/dm-core.h | 2 -- drivers/md/dm-rq.c | 9 +++--- drivers/md/dm.c | 36 +++++++++------------ drivers/md/md.c | 7 ++--- include/linux/genhd.h | 55 +++++++++++++++++++------------- 12 files changed, 137 insertions(+), 172 deletions(-)