mbox series

[0/1] dm snapshot: Fix bug in COW throttling mechanism causing deadlocks

Message ID 20191001115747.4473-1-ntsironis@arrikto.com (mailing list archive)
Headers show
Series dm snapshot: Fix bug in COW throttling mechanism causing deadlocks | expand

Message

Nikos Tsironis Oct. 1, 2019, 11:57 a.m. UTC 
Hello,

This patch fixes the deadlock issue reported in this thread:
https://www.redhat.com/archives/dm-devel/2019-September/msg00168.html.

Although I have been really careful preparing this patch, in order to
avoid any further issues, any extra review would be greatly appreciated.

Thanks,
Nikos

Nikos Tsironis (1):
  dm snapshot: Fix bug in COW throttling mechanism causing deadlocks

 drivers/md/dm-snap.c | 99 +++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 90 insertions(+), 9 deletions(-)

Comments

Mikulas Patocka Oct. 2, 2019, 10:10 a.m. UTC | #1 
On Tue, 1 Oct 2019, Nikos Tsironis wrote:

> Hello,
> 
> This patch fixes the deadlock issue reported in this thread:
> https://www.redhat.com/archives/dm-devel/2019-September/msg00168.html.
> 
> Although I have been really careful preparing this patch, in order to
> avoid any further issues, any extra review would be greatly appreciated.
> 
> Thanks,
> Nikos
> 
> Nikos Tsironis (1):
>   dm snapshot: Fix bug in COW throttling mechanism causing deadlocks
> 
>  drivers/md/dm-snap.c | 99 +++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 90 insertions(+), 9 deletions(-)

Hi

I think a better solution would be to drop all locks while waiting for 
some kcopyd job. I'll send patches for that.

Mikulas

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel