[v2,00/14] multipath: aio, systemd, and documentation improvements

Message

Martin Wilck Oct. 26, 2023, 5:41 p.m. UTC

From: Martin Wilck <[e-mail]>

This is v2 of my "multipath: aio and systemd service improvements" series.
I have shuffled the ordering around a bit and added patches to fix issues
that had come up in the v1 review. I also fixed the error handling of the
aio code in both directio.c and io_err_stat.c.

Cc: Li Xiao Keng <[e-mail]>
Cc: Miao Guanqin <[e-mail]>
Cc: Guan Junxiong <[e-mail]>
Cc: Xose Vazquez Perez <[e-mail]>

Changes since v1:
 02/14: re-added the io_cancel() call in libcheck_free() (Ben),
        changed the way I fixed the directio test
 03/14: new (error handling)
 04/14 (was 3/6): no change, fixed Ben's remark in 05/14 in 06/14
 05/14 (was 4/6): avoid cancelling requests after calling io_destroy (Ben).
 06/14: new, avoid iocb starvation (Ben's remark for 3/6)
 07/14: new (error handling)
 08/14 (was 5/6): take systemd version into account

10-14 are new, documentation changes that seem overdue.

v1 cover letter:

The bulk of this patch set comes out of my attempts to solve
https://github.com/opensvc/multipath-tools/issues/73 and the insight
that aio memory can't be freed unless either io_getevents() returns
the iocb in question as finished, or io_destroy() has returned.
aio handling in multipathd needs more work, because io_destroy()
may block for a long time, and we must avoid to block, but I would
like to postpone that to a later patch set (I plan to add a generic
aio framework to libmultipath which could then be used by both
the directio checker and the io_err_stat code, but this isn't finished yet).

The last two patches are improvements to multipathd's systemd service and
kernel module loading logic. They are unrelated to the others.

Martin Wilck (14):
  libmultipath: reduce log level of directio messages
  libmultipath: directio: don't reset ct->running after io_cancel()
  libmultipath: directio: fix error handling
  libmultipath: io_err_stat: don't free aio memory before completion
  libmultipath: io_err_stat: call io_destroy() inside
    free_io_err_pathvec()
  libmultipath: io_err_stat: use higher number of aio slots
  libmultipath: io_err_stat: fix error handling
  multipathd.service: require modprobe@dm_multipath.service if available
  libmpathutil: remove systemd_service_enabled()
  multipath.conf.5: fix typo
  Makefile.inc, README.md: fix docs for prefix in split-usr case
  README.md: update mailing list and contributing information
  README.md: Extend the section about NVMe
  README.md: fix formatting of Changelog section

 Makefile.inc                                  |  10 +-
 README.md                                     | 115 ++++++++++++------
 libmpathutil/libmpathutil.version             |  17 +--
 libmpathutil/util.c                           |  58 ---------
 libmpathutil/util.h                           |   1 -
 libmultipath/checkers/directio.c              |  33 ++---
 libmultipath/io_err_stat.c                    |  75 +++++++-----
 libmultipath/valid.c                          |  16 +--
 multipath/Makefile                            |   6 +-
 multipath/multipath.conf.5.in                 |   2 +-
 multipathd/Makefile                           |   4 +-
 ...ltipathd.service => multipathd.service.in} |   4 +-
 tests/directio.c                              |  27 +---
 tests/valid.c                                 |  24 +---
 14 files changed, 159 insertions(+), 233 deletions(-)
 rename multipathd/{multipathd.service => multipathd.service.in} (85%)