mbox series

[0/7] dm-verity cleanups and optimizations

Message ID 20240702064835.120541-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series dm-verity cleanups and optimizations | expand

Message

Eric Biggers July 2, 2024, 6:48 a.m. UTC
This series contains some cleanups and optimizations for dm-verity that
I've split out from my multibuffer hashing series
https://lore.kernel.org/linux-crypto/20240621165922.77672-1-ebiggers@kernel.org/.

This series does not depend on any crypto API changes, so it can be
applied right away.

Eric Biggers (7):
  dm-verity: move hash algorithm setup into its own function
  dm-verity: move data hash mismatch handling into its own function
  dm-verity: make real_digest and want_digest fixed-length
  dm-verity: provide dma_alignment limit in io_hints
  dm-verity: always "map" the data blocks
  dm-verity: make verity_hash() take dm_verity_io instead of
    ahash_request
  dm-verity: hash blocks with shash import+finup when possible

 drivers/md/dm-verity-fec.c    |  32 +--
 drivers/md/dm-verity-fec.h    |   6 +-
 drivers/md/dm-verity-target.c | 461 ++++++++++++++++------------------
 drivers/md/dm-verity.h        |  39 ++-
 4 files changed, 242 insertions(+), 296 deletions(-)


base-commit: 22a40d14b572deb80c0648557f4bd502d7e83826

Comments

Eric Biggers July 3, 2024, 7:15 p.m. UTC | #1
On Mon, Jul 01, 2024 at 11:48:28PM -0700, Eric Biggers wrote:
> This series contains some cleanups and optimizations for dm-verity that
> I've split out from my multibuffer hashing series
> https://lore.kernel.org/linux-crypto/20240621165922.77672-1-ebiggers@kernel.org/.
> 
> This series does not depend on any crypto API changes, so it can be
> applied right away.
> 
> Eric Biggers (7):
>   dm-verity: move hash algorithm setup into its own function
>   dm-verity: move data hash mismatch handling into its own function
>   dm-verity: make real_digest and want_digest fixed-length
>   dm-verity: provide dma_alignment limit in io_hints
>   dm-verity: always "map" the data blocks
>   dm-verity: make verity_hash() take dm_verity_io instead of
>     ahash_request
>   dm-verity: hash blocks with shash import+finup when possible
> 
>  drivers/md/dm-verity-fec.c    |  32 +--
>  drivers/md/dm-verity-fec.h    |   6 +-
>  drivers/md/dm-verity-target.c | 461 ++++++++++++++++------------------
>  drivers/md/dm-verity.h        |  39 ++-
>  4 files changed, 242 insertions(+), 296 deletions(-)

Thanks for applying this, Mikulas!

I sent out a new version of "dm-verity: provide dma_alignment limit in io_hints"
to address Christoph's comment.

Also, I noticed that when you applied the patches, patch 2 somehow ended up with
the same commit message as patch 1.  Can you fix that?  Thanks!

- Eric
Mikulas Patocka July 4, 2024, 3:05 p.m. UTC | #2
On Wed, 3 Jul 2024, Eric Biggers wrote:

> On Mon, Jul 01, 2024 at 11:48:28PM -0700, Eric Biggers wrote:
> > This series contains some cleanups and optimizations for dm-verity that
> > I've split out from my multibuffer hashing series
> > https://lore.kernel.org/linux-crypto/20240621165922.77672-1-ebiggers@kernel.org/.
> > 
> > This series does not depend on any crypto API changes, so it can be
> > applied right away.
> > 
> > Eric Biggers (7):
> >   dm-verity: move hash algorithm setup into its own function
> >   dm-verity: move data hash mismatch handling into its own function
> >   dm-verity: make real_digest and want_digest fixed-length
> >   dm-verity: provide dma_alignment limit in io_hints
> >   dm-verity: always "map" the data blocks
> >   dm-verity: make verity_hash() take dm_verity_io instead of
> >     ahash_request
> >   dm-verity: hash blocks with shash import+finup when possible
> > 
> >  drivers/md/dm-verity-fec.c    |  32 +--
> >  drivers/md/dm-verity-fec.h    |   6 +-
> >  drivers/md/dm-verity-target.c | 461 ++++++++++++++++------------------
> >  drivers/md/dm-verity.h        |  39 ++-
> >  4 files changed, 242 insertions(+), 296 deletions(-)
> 
> Thanks for applying this, Mikulas!
> 
> I sent out a new version of "dm-verity: provide dma_alignment limit in io_hints"
> to address Christoph's comment.
> 
> Also, I noticed that when you applied the patches, patch 2 somehow ended up with
> the same commit message as patch 1.  Can you fix that?  Thanks!
> 
> - Eric

Hi

It should be fixed now.

Mikulas